Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-interface.c

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-interface.c
Date	2017-01-31 22:00 +0100
Message-ID	<t5NGW-5im-25@gated-at.bofh.it> (permalink)
References	<t5L2p-3UK-9@gated-at.bofh.it> <t5M89-4ww-1@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Tue, Jan 31, 2017 at 11:10:41AM -0800, James Bottomley wrote:
> On Tue, 2017-01-31 at 20:07 +0200, Jarkko Sakkinen wrote:
> > drivers/char/tpm//tpm-interface.c:492:42: warning: bad assignment (
> > -=)
> > to restricted __be32
> > 
> > Fixes: 0883743825e3 ("TPM: sysfs functions consolidation")
> > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > ---
> >  drivers/char/tpm/tpm-interface.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm
> > -interface.c
> > index 423938e..746bc54 100644
> > --- a/drivers/char/tpm/tpm-interface.c
> > +++ b/drivers/char/tpm/tpm-interface.c
> > @@ -489,7 +489,7 @@ ssize_t tpm_getcap(struct tpm_chip *chip, u32
> > subcap_id, cap_t *cap,
> >  		tpm_cmd.params.getcap_in.cap =
> > cpu_to_be32(subcap_id);
> >  		/*subcap field not necessary */
> >  		tpm_cmd.params.getcap_in.subcap_size =
> > cpu_to_be32(0);
> > -		tpm_cmd.header.in.length -=
> > cpu_to_be32(sizeof(__be32));
> > +		tpm_cmd.header.in.length = cpu_to_be32(18);
> 
> using bare numbers here without comment isn't really best practice. 
>  What about setting header.in.length in both legs of the if() to either
> 
> tpm_cmd.header.in.length = cpu_to_be32(HEADER_SIZE + sizeof(struct tpm_getcap_params_in))
> 
> or 
> 
> /* setting subcap_size to zero allows us to elimnate the subcap field */
> tpm_cmd.header.in.length = cpu_to_be32(HEADER_SIZE + sizeof(struct tpm_getcap_params_in) - sizeof(tpm_cmd.params.getcap_in.subcap))

Yeah, also the commit message should be updated rather than
referring to the static checking tool. I'll update the commit
along the lines you proposed...

/Jarkko

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] tpm: fix a sparse error in tpm-interface.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-31 19:10 +0100
  Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-interface.c James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-01-31 20:20 +0100
    Re: [tpmdd-devel] [PATCH] tpm: fix a sparse error in tpm-interface.c Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-31 22:00 +0100

csiph-web