Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1571039

Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error return check

Show all headers | View raw

On 01/31/2017 04:53 PM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> Checking for ret < 0 is redundant because a previous check on ret
> being non-zero already handles the ret < 0 case. Remove the redundant
> code. Found by CoverityScan, CID#1398863, CID#1398864
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Acked-by: Marek Vasut <marek.vasut@gmail.com>

Thanks

> ---
>  drivers/mtd/spi-nor/cadence-quadspi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c
> index 3fb7be8..9f8102d 100644
> --- a/drivers/mtd/spi-nor/cadence-quadspi.c
> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c
> @@ -893,7 +893,7 @@ static ssize_t cqspi_write(struct spi_nor *nor, loff_t to,
>  	if (ret)
>  		return ret;
>  
> -	return (ret < 0) ? ret : len;
> +	return len;
>  }
>  
>  static ssize_t cqspi_read(struct spi_nor *nor, loff_t from,
> @@ -913,7 +913,7 @@ static ssize_t cqspi_read(struct spi_nor *nor, loff_t from,
>  	if (ret)
>  		return ret;
>  
> -	return (ret < 0) ? ret : len;
> +	return len;
>  }
>  
>  static int cqspi_erase(struct spi_nor *nor, loff_t offs)
> 


-- 
Best regards,
Marek Vasut

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error return check Colin King <colin.king@canonical.com> - 2017-01-31 17:00 +0100
  Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error  return check Richard Weinberger <richard@nod.at> - 2017-01-31 17:50 +0100
  Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error  return check Marek Vasut <marek.vasut@gmail.com> - 2017-01-31 20:50 +0100
  Re: [PATCH] mtd: spi-nor: cqspi: remove redundant dead code on error  return check Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-02-02 10:50 +0100

csiph-web