Re: [RFC] tty: pl011: Work around stuck BUSY bit on QDF2400

From	Russell King - ARM Linux <linux@armlinux.org.uk>
Newsgroups	linux.kernel
Subject	Re: [RFC] tty: pl011: Work around stuck BUSY bit on QDF2400
Date	2017-01-31 19:50 +0100
Message-ID	<t5LF8-47z-21@gated-at.bofh.it> (permalink)
References	<t5tRT-1Nt-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Jan 30, 2017 at 06:44:17PM -0500, Christopher Covington wrote:
>  {
>  	struct uart_amba_port *uap =
>  	    container_of(port, struct uart_amba_port, port);
> -	unsigned int status = pl011_read(uap, REG_FR);
> +	unsigned int status = pl011_read(uap, REG_FR) ^ uap->vendor->inv_fr;
>  	return status & (uap->vendor->fr_busy | UART01x_FR_TXFF) ?
>  							0 : TIOCSER_TEMT;
>  }

I'd much prefer the reg & mask == val approach, but the above makes that
difficult.

So for the PL011 changes:

Acked-by: Russell King <rmk+kernel@armlinux.org.uk>

Thanks.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC] tty: pl011: Work around stuck BUSY bit on QDF2400 Christopher Covington <cov@codeaurora.org> - 2017-01-31 00:50 +0100
  Re: [RFC] tty: pl011: Work around stuck BUSY bit on QDF2400 Will Deacon <will.deacon@arm.com> - 2017-01-31 16:00 +0100
  Re: [RFC] tty: pl011: Work around stuck BUSY bit on QDF2400 Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-01-31 19:50 +0100

csiph-web