Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570833

Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver

From Paul Cercueil <paul@crapouillou.net>
Newsgroups linux.kernel
Subject Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver
Date 2017-01-31 16:40 +0100
Message-ID <t5IHf-2n8-17@gated-at.bofh.it> (permalink)
References <t1iV4-Qv-5@gated-at.bofh.it> <t3AXv-5pP-3@gated-at.bofh.it> <t3AXw-5pP-35@gated-at.bofh.it> <t5HBv-1Ll-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Le 2017-01-31 15:20, Linus Walleij a écrit :

>> + of_property_read_u32(dev->of_node, "base", &jzgc->gc.base);
> 
> Remove this. Dynamic allocation should be fine, if you're using the
> new userspace ABI like tools/gpio/* or libgpiod and only that and 
> in-kernel
> consumers, dynamic numbers are just fine.

The problem is that the QI_LB60 board code still have a lot of 
references
to global GPIO numbers. Just grep for JZ_GPIO_PORT in
arch/mips/jz4740/board-qi_lb60.c to see what I mean...

-Paul

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver Linus Walleij <linus.walleij@linaro.org> - 2017-01-31 15:30 +0100
  Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver Paul Cercueil <paul@crapouillou.net> - 2017-01-31 16:40 +0100
    Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver Linus Walleij <linus.walleij@linaro.org> - 2017-02-03 15:00 +0100

csiph-web