Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570715

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM

Show all headers | View raw

On 16.01.2017 12:56, Baolin Wang wrote:
> Hi Mathias,

Hi

Sorry about the long review delay
CC Alan in case my pm assumptions need to be corrected

>
> On 13 December 2016 at 15:49, Baolin Wang <baolin.wang@linaro.org> wrote:
>> Enable the xhci plat runtime PM for parent device to suspend/resume xhci.
>> Also call pm_runtime_get_noresume() in probe() function in case the parent
>> device doesn't call suspend/resume callback by runtime PM now.
>>
>> Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>> ---
>> Changes since v4:
>>   - No updates.
>>
>> Changes since v3:
>>   - Fix kbuild error.
>>
>> Changes since v2:
>>   - Add pm_runtime_get_noresume() in probe() function.
>>   - Add pm_runtime_set_suspended()/pm_runtime_put_noidle() in remove() function.
>>
>> Changes since v1:
>>   - No updates.
>> ---
>
> Do you have any comments about this patch? Thanks.
>
>>   drivers/usb/host/xhci-plat.c |   41 ++++++++++++++++++++++++++++++++++++-----
>>   1 file changed, 36 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
>> index ed56bf9..5805c6a 100644
>> --- a/drivers/usb/host/xhci-plat.c
>> +++ b/drivers/usb/host/xhci-plat.c
>> @@ -246,6 +246,10 @@ static int xhci_plat_probe(struct platform_device *pdev)
>>          if (ret)
>>                  goto dealloc_usb2_hcd;
>>
>> +       pm_runtime_get_noresume(&pdev->dev);
>> +       pm_runtime_set_active(&pdev->dev);
>> +       pm_runtime_enable(&pdev->dev);
>> +
>>          return 0;
>>
>>

To me this looks like we are not really enabling runtime pm for xhci, we increment the
usage count in probe, and keep it until remove is called.

This would normally prevent parent dwc3 from runtime suspending, but I see that in patch 2/2 adds
pm_suspend_ignore_children(dev, true) to dwc3, and, that dwc3 actually controls xhci runtime
pm by calling pm_runtime_get/put for xhci in its own dwc3 runtime_suspend/resume callbacks.

Looks a bit upside down to me, what's the reason for this?

what prevents calling pm_runtime_put_* before leaving probe in xhci and let pm code handle
the runtime suspend and parent/child relationships?

-Mathias

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM Mathias Nyman <mathias.nyman@linux.intel.com> - 2017-01-31 14:20 +0100
  Re: [PATCH v5 1/2] usb: host: plat: Enable xhci plat runtime PM Baolin Wang <baolin.wang@linaro.org> - 2017-02-06 06:30 +0100

csiph-web