Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570699

Re: [PATCH] [RFC] fs: Possible filp_open race experiment

Show all headers | View raw

On Tue, Jan 31, 2017 at 11:21:02AM +0100, Greg Kroah-Hartman wrote:
> 
> -next isn't Linus's tree, sometimes stuff sits in there for years :)
> 
> Anyway, if this is a configfs issue, Christoph and Joel can take a look
> at it.  Any reason you didn't cc: Joel as well (the MAINTAINERS file is
> your friend...)

It's really a mismatched assumption.  The configfs binary file
code just chunks updates up into a buffer, which only gets flushed
at ->release time.  If we'd move that to ->flush the issue Marek reports
would be fixed.

But I don't think we want that - triggering a filp_open from the update
of a _binary_ attribute for a start is wrong.  And second doing this
using ->fs of a random calling process is bound to cause problems.

I think he is using the wrong kind of interface for the job.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] [RFC] fs: Possible filp_open race experiment Marek Vasut <marex@denx.de> - 2017-01-31 06:50 +0100
  Re: [PATCH] [RFC] fs: Possible filp_open race experiment Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-31 08:10 +0100
    Re: [PATCH] [RFC] fs: Possible filp_open race experiment Marek Vasut <marex@denx.de> - 2017-01-31 11:20 +0100
      Re: [PATCH] [RFC] fs: Possible filp_open race experiment Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-31 11:50 +0100
        Re: [PATCH] [RFC] fs: Possible filp_open race experiment Christoph Hellwig <hch@lst.de> - 2017-01-31 14:00 +0100
          Re: [PATCH] [RFC] fs: Possible filp_open race experiment Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-31 14:20 +0100
            Re: [PATCH] [RFC] fs: Possible filp_open race experiment Marek Vasut <marex@denx.de> - 2017-01-31 22:10 +0100

csiph-web