Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570758

Re: [PATCH] x86/mce: Make timer handling more robust

Show all headers | View raw

On Tue, 31 Jan 2017, Thomas Gleixner wrote:
> +static void mce_start_timer(struct timer_list *t)
>  {
>  	unsigned long iv = check_interval * HZ;
>  
>  	if (mca_cfg.ignore_ce || !iv)
>  		return;
>  
> -	per_cpu(mce_next_interval, cpu) = iv;
> -
> -	t->expires = round_jiffies(jiffies + iv);
> -	add_timer_on(t, cpu);
> +	this_cpu_write(mce_next_interval, iv);
> +	__start_timer(t, jiffies + iv);

Bah. That's wrong. Delta patch below:

--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -1782,7 +1782,7 @@ static void mce_start_timer(struct timer
 		return;
 
 	this_cpu_write(mce_next_interval, iv);
-	__start_timer(t, jiffies + iv);
+	__start_timer(t, iv);
 }
 
 static void __mcheck_cpu_setup_timer(void)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] x86/mce: Make timer handling more robust Thomas Gleixner <tglx@linutronix.de> - 2017-01-31 09:40 +0100
  Re: [PATCH] x86/mce: Make timer handling more robust Thomas Gleixner <tglx@linutronix.de> - 2017-01-31 14:40 +0100
    Re: [PATCH] x86/mce: Make timer handling more robust Borislav Petkov <bp@alien8.de> - 2017-01-31 19:40 +0100
      Re: [PATCH] x86/mce: Make timer handling more robust "Veijola, Erik" <erik.veijola@intel.com> - 2017-02-01 10:30 +0100
  Re: [PATCH] x86/mce: Make timer handling more robust Borislav Petkov <bp@alien8.de> - 2017-01-31 19:40 +0100
  [tip:x86/urgent] x86/mce: Make timer handling more robust tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2017-01-31 22:50 +0100

csiph-web