Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board
Date	2017-01-31 12:40 +0100
Message-ID	<t5EX1-8E-29@gated-at.bofh.it> (permalink)
References	(4 earlier) <t5ubg-28G-9@gated-at.bofh.it> <t5CVc-7pw-23@gated-at.bofh.it> <t5D4R-7sP-1@gated-at.bofh.it> <t5DxV-7RQ-37@gated-at.bofh.it> <t5EaC-84y-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jan 31, 2017 at 12:37 PM, Inki Dae <daeinki@gmail.com> wrote:
> 2017-01-31 19:01 GMT+09:00 Krzysztof Kozlowski <krzk@kernel.org>:
>> On Tue, Jan 31, 2017 at 11:34 AM, Inki Dae <inki.dae@samsung.com> wrote:
>>>
>>>
>>> 2017년 01월 31일 18:22에 Krzysztof Kozlowski 이(가) 쓴 글:
>>>> On Tue, Jan 31, 2017 at 2:01 AM, Inki Dae <inki.dae@samsung.com> wrote:
>>>>>
>>>>>
>>>>> 2017년 01월 24일 10:50에 Hoegeun Kwon 이(가) 쓴 글:
>>>>>> Dear Thierry,
>>>>>>
>>>>>> Could you please review this patch?
>>>>>
>>>>> Thierry, I think this patch has been reviewed enough but no comment from you. Seems you are busy. I will pick up this.
>>>>>
>>>>
>>>> Comments from v8 were not resolved and I think we are waiting for v9:
>>>> https://lkml.org/lkml/2017/1/11/178
>>>>
>>>> If that is not correct then please clarify.
>>>
>>> Seems you pointed to change te-gpios bindings to optional. right?
>>>
>>> I thought Rob left ack so it's no problem.
>>> https://lkml.org/lkml/2017/1/13/626
>>
>> Yes, change them to optional. I think it is a problem (regardless of
>> Rob's ack) because you are merging a driver requiring a property which
>> soon you want to remove. If you merge it (like this) removal of
>> te-gpios property will be breakage of ABI. This is not a serious
>> problem but knowing such plan of te-gpios removal upfront, it would be
>> wrong to commit such driver.
>
> This is a trivial thing so it doesn't make breakage of ABI because the
> property, te-gpios, is *optional*.

So why bindings document is not changed?

+Required properties:
(...)
+  - te-gpios: a GPIO spec for the tearing effect synchronization signal
+    gpio pin (active high)

Andrzej pointed this out and it is not fixed since then. What is the
problem with fixing the bindings documentation?

> Anyway, this wouldn't be *the things* Thierry mentioned.

Probably not, I did not respond to Thierry's feedback.

Best regards,
Krzysztof

Thread

Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-01-31 01:10 +0100
  Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-01-31 10:00 +0100
    Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-01-31 10:30 +0100
    Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-01-31 13:10 +0100
      Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-02 19:00 +0100
        Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-02-03 10:00 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Daniel Vetter <daniel@ffwll.ch> - 2017-02-03 10:00 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-02-06 10:20 +0100
              Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Daniel Vetter <daniel@ffwll.ch> - 2017-02-06 10:50 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-06 11:40 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Andrzej Hajda <a.hajda@samsung.com> - 2017-02-07 11:00 +0100
    Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Sean Paul <seanpaul@chromium.org> - 2017-01-31 15:50 +0100
      Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-01-31 16:10 +0100
        Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Sean Paul <seanpaul@chromium.org> - 2017-01-31 17:00 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-01-31 22:30 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Emil Velikov <emil.l.velikov@gmail.com> - 2017-01-31 22:50 +0100
        Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Eric Anholt <eric@anholt.net> - 2017-01-31 19:30 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-01-31 22:40 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Eric Anholt <eric@anholt.net> - 2017-02-01 00:00 +0100
              Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-01 16:00 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Emil Velikov <emil.l.velikov@gmail.com> - 2017-02-01 16:30 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Sean Paul <seanpaul@chromium.org> - 2017-02-01 20:10 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-02-03 06:50 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-02-03 05:50 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-02-01 01:00 +0100
              Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-01 15:50 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-02-02 13:50 +0100
                Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-02 21:00 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on TM2 board Jani Nikula <jani.nikula@linux.intel.com> - 2017-02-02 16:40 +0100
              Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-02-02 17:50 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Thierry Reding <thierry.reding@gmail.com> - 2017-01-31 23:00 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver  on TM2 board Daniel Vetter <daniel@ffwll.ch> - 2017-02-02 15:30 +0100
  Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-31 10:30 +0100
    Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <inki.dae@samsung.com> - 2017-01-31 10:40 +0100
      Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-31 11:10 +0100
        Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <daeinki@gmail.com> - 2017-01-31 11:50 +0100
          Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-31 12:40 +0100
            Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Inki Dae <daeinki@gmail.com> - 2017-01-31 14:10 +0100
    Re: [PATCH v8 2/3] drm/panel: Add support for S6E3HA2 panel driver on  TM2 board Hoegeun Kwon <hoegeun.kwon@samsung.com> - 2017-02-01 06:50 +0100

csiph-web