Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()

From	Ursula Braun <ubraun@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero()
Date	2017-01-31 12:30 +0100
Message-ID	<t5ENk-5s-11@gated-at.bofh.it> (permalink)
References	<t5pbA-7p2-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

ACK - compile-tested successfully on s390.

On 01/30/2017 07:47 PM, Fabian Frederick wrote:
> instead of atomic_add_unless(value, -1, 0)
> 
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/s390/net/qeth_core_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c
> index 315d8a2..9595b90 100644
> --- a/drivers/s390/net/qeth_core_main.c
> +++ b/drivers/s390/net/qeth_core_main.c
> @@ -3278,7 +3278,7 @@ void qeth_queue_input_buffer(struct qeth_card *card, int index)
>  			atomic_set(&card->force_alloc_skb, 3);
>  			count = newcount;
>  		} else {
> -			atomic_add_unless(&card->force_alloc_skb, -1, 0);
> +			atomic_dec_not_zero(&card->force_alloc_skb);
>  		}
> 
>  		if (!count) {
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 06/14] s390/qeth: use atomic_dec_not_zero() Fabian Frederick <fabf@skynet.be> - 2017-01-30 19:50 +0100
  Re: [PATCH 06/14] s390/qeth: use atomic_dec_not_zero() Ursula Braun <ubraun@linux.vnet.ibm.com> - 2017-01-31 12:30 +0100

csiph-web