Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570572

Re: [PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring

Show all headers | View raw

On 1/31/2017 10:11 AM, Corentin Labbe wrote:
> The u64 x variable in sysfs_display_ring is unused.
> This patch remove it.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>


well spot

Acked-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>


> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> index b494bc2..f0ce780 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
> @@ -2890,9 +2890,7 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
>  	struct dma_desc *p = (struct dma_desc *)head;
>
>  	for (i = 0; i < size; i++) {
> -		u64 x;
>  		if (extend_desc) {
> -			x = *(u64 *) ep;
>  			seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
>  				   i, (unsigned int)virt_to_phys(ep),
>  				   le32_to_cpu(ep->basic.des0),
> @@ -2901,7 +2899,6 @@ static void sysfs_display_ring(void *head, int size, int extend_desc,
>  				   le32_to_cpu(ep->basic.des3));
>  			ep++;
>  		} else {
> -			x = *(u64 *) p;
>  			seq_printf(seq, "%d [0x%x]: 0x%x 0x%x 0x%x 0x%x\n",
>  				   i, (unsigned int)virt_to_phys(ep),
>  				   le32_to_cpu(p->des0), le32_to_cpu(p->des1),
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 16/17] net: stmmac: remove unused variable in sysfs_display_ring Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-01-31 10:30 +0100
  Re: [PATCH 16/17] net: stmmac: remove unused variable in  sysfs_display_ring Giuseppe CAVALLARO <peppe.cavallaro@st.com> - 2017-01-31 11:20 +0100

csiph-web