Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1570482
| From | Michael Ellerman <mpe@ellerman.id.au> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: ibmvtpm byteswapping inconsistency |
| Date | 2017-01-31 09:40 +0100 |
| Message-ID | <t5C8O-6Tr-17@gated-at.bofh.it> (permalink) |
| References | (2 earlier) <t44LT-6Tn-1@gated-at.bofh.it> <t4bDI-2M6-31@gated-at.bofh.it> <t4pwZ-2N2-5@gated-at.bofh.it> <t5bV0-7TO-3@gated-at.bofh.it> <t5qU1-4V-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
> On 01/29/2017 08:32 PM, Michael Ellerman wrote:
>> Tyrel Datwyler <tyreld@linux.vnet.ibm.com> writes:
>>>
>>> Byte | 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7
>>> -----------------------------------------------------------------------
>>> Word0 | Valid | Type | Length | Data
>>> -----------------------------------------------------------------------
>>> Word1 | Reserved
>>> -----------------------------------------------------------------------
>>>
>>> The following definition looks to match:
>>>
>>> struct ibmvtpm_crq {
>>> u8 valid;
>>> u8 msg;
>>> __be16 len;
>>> __be32 data;
>>> __be64 reserved;
>>> } __attribute__((packed, aligned(8)));
>>
>> Well it's a partial match.
>>
>> Your layout above doesn't define which byte of Length or Data is the MSB
>> or LSB. So going by that we still don't know the endianness of either
>
> I should have been explicit that PAPR uses Big Endian bit and byte
> numbering throughout the spec unless otherwise noted.
OK. I didn't actually remember that so yeah good to be explicit.
cheers
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
ibmvtpm byteswapping inconsistency Michal Suchánek <msuchanek@suse.de> - 2017-01-26 21:30 +0100
Re: ibmvtpm byteswapping inconsistency Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2017-01-26 23:10 +0100
Re: ibmvtpm byteswapping inconsistency Michal Suchanek <hramrach@gmail.com> - 2017-01-26 23:50 +0100
Re: ibmvtpm byteswapping inconsistency Ashley Lai <ashleydlai@gmail.com> - 2017-01-27 00:00 +0100
Re: ibmvtpm byteswapping inconsistency Vicky <honclo@linux.vnet.ibm.com> - 2017-02-02 05:50 +0100
Re: ibmvtpm byteswapping inconsistency Michael Ellerman <mpe@ellerman.id.au> - 2017-02-02 12:00 +0100
Re: ibmvtpm byteswapping inconsistency Michal Suchánek <msuchanek@suse.de> - 2017-02-02 12:50 +0100
RE: ibmvtpm byteswapping inconsistency David Laight <David.Laight@ACULAB.COM> - 2017-02-02 16:20 +0100
Re: ibmvtpm byteswapping inconsistency Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-01-27 02:50 +0100
Re: ibmvtpm byteswapping inconsistency Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-01-27 03:50 +0100
Re: ibmvtpm byteswapping inconsistency Michal Suchanek <hramrach@gmail.com> - 2017-01-27 11:10 +0100
Re: ibmvtpm byteswapping inconsistency Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-01-28 02:00 +0100
Re: ibmvtpm byteswapping inconsistency Michael Ellerman <mpe@ellerman.id.au> - 2017-01-30 05:40 +0100
Re: ibmvtpm byteswapping inconsistency Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-01-30 21:40 +0100
Re: ibmvtpm byteswapping inconsistency Michael Ellerman <mpe@ellerman.id.au> - 2017-01-31 09:40 +0100
Re: ibmvtpm byteswapping inconsistency Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-01-27 21:30 +0100
Re: ibmvtpm byteswapping inconsistency Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-01-27 21:50 +0100
Re: ibmvtpm byteswapping inconsistency Tyrel Datwyler <tyreld@linux.vnet.ibm.com> - 2017-01-28 00:50 +0100
Re: ibmvtpm byteswapping inconsistency msuchanek <msuchanek@suse.de> - 2017-01-28 01:40 +0100
Re: ibmvtpm byteswapping inconsistency Benjamin Herrenschmidt <benh@kernel.crashing.org> - 2017-01-28 05:40 +0100
RE: ibmvtpm byteswapping inconsistency David Laight <David.Laight@ACULAB.COM> - 2017-01-30 15:50 +0100
RE: ibmvtpm byteswapping inconsistency David Laight <David.Laight@ACULAB.COM> - 2017-01-27 12:50 +0100
csiph-web