Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1570472

Re: [PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On 29/01/2017 17:47, Sebastian Reichel wrote:
> Hi,
> 
> On Fri, Jan 27, 2017 at 09:54:49AM +0100, Quentin Schulz wrote:
>>  - added x-powers,constant-charge-current property to set the
>>  maximal default constant current charge of the battery,
> 
> Since this is information about the battery and not the fuel-gauge,
> it should use the WIP "framework" for information about batteries.
> 
> Have a look at the following patchset:
> 
> http://marc.info/?l=linux-pm&m=148411561025684&w=2
> 

OK. So what you propose is to have a fourth property in this new
structure named design-max-constant-charge-current that gives the
maximal input amperage the battery can receive?

Then, I set the charger to output a maximum of this amperage by default
and let the user the possibility to choose between the minimum allowed
by the PMIC and the maximum allowed by the battery from sysfs. That
makes more sense than what I do here in the way that I didn't protect a
possible over-amperage of the battery, thing that Chen-Yu was afraid
some users would do.

I've a comment on the linked patches however. Though the three
properties are listed as optional in the binding-dt, the implementation
is saying the opposite:

http://marc.info/?l=linux-pm&m=148411561725693&w=2

If I'm not mistaken, if `nominal-microvolt' or `design-microwatt-hours'
is not a property of the DT node, power_supply_get_battery_info will
return without parsing the other properties and even return a negative
error.

Thanks,
Quentin
-- 
Quentin Schulz, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 00/25] add support for AXP20X and AXP22X power supply drivers Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 15:40 +0100
  [PATCH v2 03/25] power: supply: axp20x_usb_power: use IIO channels when available Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 16:00 +0100
    Re: [PATCH v2 03/25] power: supply: axp20x_usb_power: use IIO  channels when available Jonathan Cameron <jic23@kernel.org> - 2017-01-28 16:00 +0100
    Re: [PATCH v2 03/25] power: supply: axp20x_usb_power: use IIO  channels when available Sebastian Reichel <sre@kernel.org> - 2017-01-29 17:30 +0100
  [PATCH v2 04/25] iio: adc: add support for X-Powers AXP20X and AXP22X PMICs ADCs Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 16:10 +0100
    Re: [PATCH v2 04/25] iio: adc: add support for X-Powers AXP20X and  AXP22X PMICs ADCs Jonathan Cameron <jic23@kernel.org> - 2017-01-28 16:00 +0100
      Re: [PATCH v2 04/25] iio: adc: add support for X-Powers AXP20X and  AXP22X PMICs ADCs Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-28 16:30 +0100
        Re: [PATCH v2 04/25] iio: adc: add support for X-Powers AXP20X and  AXP22X PMICs ADCs Jonathan Cameron <jic23@kernel.org> - 2017-01-28 16:40 +0100
  [PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X battery DT binding Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 16:50 +0100
    Re: [PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X  battery DT binding Sebastian Reichel <sre@kernel.org> - 2017-01-29 18:00 +0100
      Re: [PATCH v2 16/25] dt-bindings: power: supply: add AXP20X/AXP22X  battery DT binding Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-31 09:10 +0100
  [PATCH v2 21/25] mfd: axp20x: add MFD cells for AXP20X and AXP22X battery driver Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 18:50 +0100
  [PATCH v2 23/25] ARM: dtsi: axp22x: add battery power supply subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 19:10 +0100
  [PATCH v2 19/25] iio: adc: axp20x_adc: map battery IIO channels Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 19:20 +0100
    Re: [PATCH v2 19/25] iio: adc: axp20x_adc: map battery IIO channels Jonathan Cameron <jic23@kernel.org> - 2017-01-28 16:10 +0100
      Re: [PATCH v2 19/25] iio: adc: axp20x_adc: map battery IIO channels Chen-Yu Tsai <wens@csie.org> - 2017-01-31 06:40 +0100
  [PATCH v2 25/25] ARM: sun5i: chip: enable battery power supply subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 19:40 +0100
  [PATCH v2 18/25] mfd: axp20x: add V_OFF to writeable regs for AXP20X and AXP22X Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 19:50 +0100
  [PATCH v2 22/25] ARM: dtsi: axp209: add battery power supply subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 20:10 +0100
  [PATCH v2 24/25] ARM: dts: sun8i: sina33: enable battery power supply subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 20:20 +0100
  [PATCH v2 15/25] ARM: sun5i: chip: enable ACIN power supply subnode Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 20:30 +0100
    Re: [PATCH v2 15/25] ARM: sun5i: chip: enable ACIN power supply subnode Chen-Yu Tsai <wens@csie.org> - 2017-01-31 06:10 +0100
  [PATCH v2 20/25] power: supply: add battery driver for AXP20X and AXP22X PMICs Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-01-27 20:50 +0100
    Re: [PATCH v2 20/25] power: supply: add battery driver for AXP20X and  AXP22X PMICs Jonathan Cameron <jic23@kernel.org> - 2017-01-28 16:30 +0100

csiph-web