Re: [PATCH 3/3] ima_fs: Move three error code assignments in ima_write_policy()

From	James Morris <jmorris@namei.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ima_fs: Move three error code assignments in ima_write_policy()
Date	2017-01-30 01:50 +0100
Message-ID	<t58kp-5Er-1@gated-at.bofh.it> (permalink)
References	<t3sdA-8r2-37@gated-at.bofh.it> <t3sdB-8r2-55@gated-at.bofh.it> <t4e8x-4cY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 27 Jan 2017, Mimi Zohar wrote:

> On Wed, 2017-01-25 at 10:34 +0100, SF Markus Elfring wrote:
> > From: Markus Elfring <elfring@users.sourceforge.net>
> > Date: Tue, 24 Jan 2017 22:47:07 +0100
> > 
> > A local variable was set to an error code in three cases before a concrete
> > error situation was detected. Thus move the corresponding assignments into
> > if branches to indicate a software failure there.
> > 
> > This issue was detected by using the Coccinelle software.
> 
> This coding style was pretty common.  I assume the compiler is smart
> enough to do the right thing.  Is this a FYI, letting us know for the
> future the preferred coding style, or are we really upstreaming these
> sorts of coding style changes?

Nope, and I generally don't want cleanup patches from Markus going into 
the security tree.

See also:
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1254425.html


- James
-- 
James Morris
<jmorris@namei.org>

Thread

[PATCH 0/3] ima_fs: Fine-tuning for ima_write_policy() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-25 10:40 +0100
  [PATCH 3/3] ima_fs: Move three error code assignments in  ima_write_policy() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-25 10:40 +0100
    Re: [PATCH 3/3] ima_fs: Move three error code assignments in  ima_write_policy() Mimi Zohar <zohar@linux.vnet.ibm.com> - 2017-01-27 13:50 +0100
      Re: [PATCH 3/3] ima_fs: Move three error code assignments in  ima_write_policy() James Morris <jmorris@namei.org> - 2017-01-30 01:50 +0100
  [PATCH 2/3] ima_fs: Reorder input parameter validation in  ima_write_policy() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-25 10:40 +0100

csiph-web