Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1569322

Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure

Show all headers | View raw

> On Sat, 2017-01-21 at 19:40 -0500, James Simmons wrote:
> > The upstream kernel requires proper structures so
> > convert nearly all the LNet wire protocols typedefs in
> > the LNet core.
> 
> Thanks.
> 
> Perhaps s/\bWIRE_ATTR\b/__packed/g one day too

I liked to keep that one. The point of WIRE_ATTR isn't to be
some abstraction but to label that struct as something that
goes over the wire. This lets people know that it would break
something if you change that structure. Looks like I need to
send a patch that adds a comment explaning the meaning of
WIRE_ATTR.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs to proper structure James Simmons <jsimmons@infradead.org> - 2017-01-22 01:50 +0100
  [PATCH 4/8] staging: lustre: lnet: change lnet_process_id_packed_t to proper structure James Simmons <jsimmons@infradead.org> - 2017-01-22 01:50 +0100
  Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol  typedefs to proper structure Joe Perches <joe@perches.com> - 2017-01-23 22:10 +0100
    Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs  to proper structure James Simmons <jsimmons@infradead.org> - 2017-01-30 01:00 +0100
      Re: [PATCH 0/8] staging: lustre: lnet: change wire protocol typedefs  to proper structure Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-30 07:50 +0100

csiph-web