Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1568840

Re: [PATCH] IB/cma: Fix reversed test

Show all headers | View raw

On Fri, Jan 27, 2017 at 07:05:52PM -0500, Doug Ledford wrote:
> > Do you think this patch needs "Fixes:" and "Cc: stable" tags?
> 
> It does not.

We always should have fixes tags.

When I'm reviewing, I try to look up the patch which introduced the bug
so I can figure out what the intent was.  Having a Fixes tag speeds up
my work.

Looking at how the bug was introduced sometimes helps to prevent bugs
from recurring in the future.  For example, I've seen several bugs
introduced because the right people weren't on the CC to review it.  For
this particular bug it feels like probably this bug could have been
detected with more testing.  I doubt it would have made it into a
released kernel.

Also it let's you CC the original authors and hopefully they can Ack it.

regards,
dan carpenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] IB/cma: Fix reversed test Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-01-27 14:20 +0100
  Re: [PATCH] IB/cma: Fix reversed test Doug Ledford <dledford@redhat.com> - 2017-01-27 20:40 +0100
  Re: [PATCH] IB/cma: Fix reversed test Doug Ledford <dledford@redhat.com> - 2017-01-28 01:10 +0100
    Re: [PATCH] IB/cma: Fix reversed test Dan Carpenter <dan.carpenter@oracle.com> - 2017-01-28 08:10 +0100
      Re: [PATCH] IB/cma: Fix reversed test Majd Dibbiny <majd@mellanox.com> - 2017-01-28 14:10 +0100
    Re: [PATCH] IB/cma: Fix reversed test Majd Dibbiny <majd@mellanox.com> - 2017-01-28 14:10 +0100

csiph-web