Re: net: suspicious RCU usage in nf_hook

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Cong Wang <xiyou.wangcong@gmail.com>
Newsgroups	linux.kernel
Subject	Re: net: suspicious RCU usage in nf_hook
Date	Sat, 28 Jan 2017 00:30:02 +0100
Message-ID	<t4o7U-241-13@gated-at.bofh.it> (permalink)
References	<t4mSt-1o8-3@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Z+NDlSt8p+w1D9PYAY4/TxhFlaMlovrjHGAJRVzDgcA=; b=WV1FhcLS9J8QLqv70BLgtkKD8+w8bHt/koR3W0Lk4wnfCedXyXWokAGX+DiASys1E1 dfa/k4HDlurp2T84+f/RxWMFvT7RN7a/V2t71l5nvBqgTrgHhie/FiMaY+fRPApT4zM7 wGeIOZWU+fcS50+aPkJnNXQC8Ryz1Hypzukfh3Uc/a1U+bwV4KZpGBwARcFJjjWqr/uN f/foqQKB2YIHk3kRdhl2718kwn1H0VBKEASdK8EIMFTuc8BNc/iMLIAuHn6Z5/esa3+l FYc7Ni3TO38bIGUGRsJODgWggIpplQ7fWg+2DI1tQqjvYRpLq4KgAaPucrhBYkMPf74q ujXA==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Z+NDlSt8p+w1D9PYAY4/TxhFlaMlovrjHGAJRVzDgcA=; b=kKuDpGxs90BmejdXzy2Etm/wGmpax7A96xREnx287drGVZ/DiIdps77oWkqud3MHKJ p/MteSsrwPquET3f0QCpUH+dmah2N+QP8k/b284vmjgq0KMIgTuzmjN3E44jEE3n2jkQ v9E6q2J93vEabQmqmAuItPVHj0vutQnlGNwwkOC8QmOqayCzEqP1TcX2LwTIaUYZryOH OV3CqRkOiFeoIWxWEgbpeVxNXYfXewsWHZregUjzcAA4/aknmTpnQBbZZ/3yyWtrhSj1 cLEutZfVD64Fi1VFCvi9VjTDEAZ62IZ+JLd+plyPnd+24Wp5y0Y4pl4SRJnma/KsxYOx Vrmg==
X-Gm-Message-State	AIkVDXJo6g6EE76Cj77HK4EqxpuUxhl0+gowsHetMVo4KulNFuzNR2I+AMUf8nl+SVCtxfyQ1kdGvnn1F45peg==
X-Received	by 10.28.0.73 with SMTP id 70mr4790503wma.109.1485559384158; Fri, 27 Jan 2017 15:23:04 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	David Miller <davem@davemloft.net>, Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>, Eric Dumazet <edumazet@google.com>, James Morris <jmorris@namei.org>, Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>, Patrick McHardy <kaber@trash.net>, netdev <netdev@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org, syzkaller <syzkaller@googlegroups.com>
X-Original-Date	Fri, 27 Jan 2017 15:22:43 -0800
X-Original-Message-ID	<CAM_iQpXNwZbkF+zoR5qdREcK6ZFt3ODbrpRB38WidLkcUWt5dw@mail.gmail.com>
X-Original-References	<CACT4Y+bpmwj1WH7g6inQBm+7PvHepv9tTmYBUqkJYFvquGDYCQ@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1568781

Show key headers only | View raw

On Fri, Jan 27, 2017 at 1:15 PM, Dmitry Vyukov <dvyukov@google.com> wrote:
> stack backtrace:
> CPU: 2 PID: 23111 Comm: syz-executor14 Not tainted 4.10.0-rc5+ #192
> Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011
> Call Trace:
>  __dump_stack lib/dump_stack.c:15 [inline]
>  dump_stack+0x2ee/0x3ef lib/dump_stack.c:51
>  lockdep_rcu_suspicious+0x139/0x180 kernel/locking/lockdep.c:4452
>  rcu_preempt_sleep_check include/linux/rcupdate.h:560 [inline]
>  ___might_sleep+0x560/0x650 kernel/sched/core.c:7748
>  __might_sleep+0x95/0x1a0 kernel/sched/core.c:7739
>  mutex_lock_nested+0x24f/0x1730 kernel/locking/mutex.c:752
>  atomic_dec_and_mutex_lock+0x119/0x160 kernel/locking/mutex.c:1060
>  __static_key_slow_dec+0x7a/0x1e0 kernel/jump_label.c:149
>  static_key_slow_dec+0x51/0x90 kernel/jump_label.c:174
>  net_disable_timestamp+0x3b/0x50 net/core/dev.c:1728
>  sock_disable_timestamp+0x98/0xc0 net/core/sock.c:403
>  __sk_destruct+0x27d/0x6b0 net/core/sock.c:1441
>  sk_destruct+0x47/0x80 net/core/sock.c:1460

jump label uses a mutex and we call jump label API in softIRQ context...
Maybe we have to move it to a work struct as what we did for netlink.

Thread

net: suspicious RCU usage in nf_hook Dmitry Vyukov <dvyukov@google.com> - 2017-01-27 23:10 +0100
  Re: net: suspicious RCU usage in nf_hook Cong Wang <xiyou.wangcong@gmail.com> - 2017-01-28 00:30 +0100
    Re: net: suspicious RCU usage in nf_hook Cong Wang <xiyou.wangcong@gmail.com> - 2017-01-28 00:40 +0100
  Re: net: suspicious RCU usage in nf_hook Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-28 00:50 +0100
    Re: net: suspicious RCU usage in nf_hook Cong Wang <xiyou.wangcong@gmail.com> - 2017-01-28 02:10 +0100
      Re: net: suspicious RCU usage in nf_hook Eric Dumazet <eric.dumazet@gmail.com> - 2017-01-28 02:40 +0100

csiph-web