Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues

From	Joe Perches <joe@perches.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues
Date	2017-01-27 22:20 +0100
Message-ID	<t4m66-Rh-7@gated-at.bofh.it> (permalink)
References	<t4kxj-8fo-5@gated-at.bofh.it> <t4lWq-NN-45@gated-at.bofh.it> <t4lWq-NN-43@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-01-27 at 22:00 +0100, Johannes Berg wrote:
> On Fri, 2017-01-27 at 22:26 +0300, Pichugin Dmitry wrote:
> > This fixes the checkpatch.pl warnings:
> > * Macros should not use a trailing semicolon.
> > * Spaces required around that '='.
> > * Symbolic permissions 'S_IRUGO' are not preferred.
> > * Macro argument reuse 'buflen' - possible side-effects
> 
> I really see no point in any of this.

Look at the uses of DEBUGFS_READONLY_FILE and
see if they are consistent before and after.

 DEBUGFS_READONLY_FILE(rts_threshold, 20, "%d",
-                     wiphy->rts_threshold)
+                     wiphy->rts_threshold);
 DEBUGFS_READONLY_FILE(fragmentation_threshold, 20, "%d",
                      wiphy->frag_threshold);
 DEBUGFS_READONLY_FILE(short_retry_limit, 20, "%d",
-                     wiphy->retry_short)
+                     wiphy->retry_short);
 DEBUGFS_READONLY_FILE(long_retry_limit, 20, "%d",
                      wiphy->retry_long);

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Pichugin Dmitry <smokeman85@gmail.com> - 2017-01-27 20:40 +0100
  Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Joe Perches <joe@perches.com> - 2017-01-27 20:50 +0100
    Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Dmitriy Pichugin <smokeman85@gmail.com> - 2017-01-28 13:00 +0100
  Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Johannes Berg <johannes@sipsolutions.net> - 2017-01-27 22:10 +0100
    Re: [PATCH] cfg80211 debugfs: Cleanup some checkpatch issues Joe Perches <joe@perches.com> - 2017-01-27 22:20 +0100

csiph-web