[PATCH 1/4] tty/vt/keyboard: use defined macros for masks

From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/4] tty/vt/keyboard: use defined macros for masks
Date	2017-01-27 18:20 +0100
Message-ID	<t4ilP-6Xe-17@gated-at.bofh.it> (permalink)
References	<t4ilP-6Xe-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Better using the defined macros to express the bit masks.

Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/tty/vt/keyboard.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/tty/vt/keyboard.c b/drivers/tty/vt/keyboard.c
index 3dd6a49..4a3907e 100644
--- a/drivers/tty/vt/keyboard.c
+++ b/drivers/tty/vt/keyboard.c
@@ -1044,9 +1044,9 @@ static int kbd_update_leds_helper(struct input_handle *handle, void *data)
 	unsigned int leds = *(unsigned int *)data;
 
 	if (test_bit(EV_LED, handle->dev->evbit)) {
-		input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & 0x01));
-		input_inject_event(handle, EV_LED, LED_NUML,    !!(leds & 0x02));
-		input_inject_event(handle, EV_LED, LED_CAPSL,   !!(leds & 0x04));
+		input_inject_event(handle, EV_LED, LED_SCROLLL, !!(leds & BIT(VC_SCROLLOCK)));
+		input_inject_event(handle, EV_LED, LED_NUML,    !!(leds & BIT(VC_NUMLOCK)));
+		input_inject_event(handle, EV_LED, LED_CAPSL,   !!(leds & BIT(VC_CAPSLOCK)));
 		input_inject_event(handle, EV_SYN, SYN_REPORT, 0);
 	}
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] tty/vt/keyboard: use defined macros for masks Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-01-27 18:20 +0100
  Re: [PATCH 1/4] tty/vt/keyboard: use defined macros for masks Samuel Thibault <samuel.thibault@ens-lyon.org> - 2017-01-27 18:20 +0100

csiph-web