[PATCH] sched/clock: add dummy clear_sched_clock_stable stub function

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!2.eu.feeder.erje.net!news2.arglkargh.de!news.albasani.net!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Paul Gortmaker <paul.gortmaker@windriver.com>
Newsgroups	linux.kernel
Subject	[PATCH] sched/clock: add dummy clear_sched_clock_stable stub function
Date	Fri, 27 Jan 2017 18:50:02 +0100
Message-ID	<t4iOS-78e-19@gated-at.bofh.it> (permalink)
X-Mailer	git-send-email 2.11.0
MIME-Version	1.0
Content-Type	text/plain
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	41
Organization	linux.* mail to news gateway
X-Original-Cc	Paul Gortmaker <paul.gortmaker@windriver.com>, Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@kernel.org>
X-Original-Date	Fri, 27 Jan 2017 12:38:16 -0500
X-Original-Message-ID	<20170127173816.22733-1-paul.gortmaker@windriver.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1568563

Show key headers only | View raw

In commit acb04058de49458010c44bb35b849d45113fd668 ("sched/clock:
Fix hotplug crash") the parisc code gained a call to this function.

However the prototype for it is within HAVE_UNSTABLE_SCHED_CLOCK
ifdef/endif.  That, combined with this:

  arch/parisc/Kconfig:    select HAVE_UNSTABLE_SCHED_CLOCK if SMP

means that parisc can have it either enabled or disabled, resulting
in the following build fail:

arch/parisc/kernel/setup.c:180:2: error: implicit declaration of
function 'clear_sched_clock_stable' [-Werror=implicit-function-declaration]

Add a no-op stub for the non-SMP case to prevent this.

Fixes: acb04058de49 ("sched/clock: Fix hotplug crash")
Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 include/linux/sched.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/linux/sched.h b/include/linux/sched.h
index 43c4840c0485..c8a257fde056 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -2498,6 +2498,10 @@ static inline void sched_clock_tick(void)
 {
 }
 
+static inline void clear_sched_clock_stable(void)
+{
+}
+
 static inline void sched_clock_idle_sleep_event(void)
 {
 }
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] sched/clock: add dummy clear_sched_clock_stable stub function Paul Gortmaker <paul.gortmaker@windriver.com> - 2017-01-27 18:50 +0100

csiph-web