Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code
Date	2017-01-27 16:20 +0100
Message-ID	<t4gtH-5Mm-3@gated-at.bofh.it> (permalink)
References	<t3y9k-3Do-9@gated-at.bofh.it> <t3y9k-3Do-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jan 25, 2017 at 10:52:31AM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the __tlbi macros, which will allow an errata
> workaround that repeats tlbi dsb sequences to only change one location.
> This is not intended to change the generated assembly and comparing before
> and after vmlinux objdump shows no functional changes.
> 
> Signed-off-by: Christopher Covington <cov@codeaurora.org>
> ---
>  arch/arm64/kvm/hyp/tlb.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)

[...]

> @@ -82,7 +83,7 @@ void __hyp_text __kvm_tlb_flush_local_vmid(struct kvm_vcpu *vcpu)
>  void __hyp_text __kvm_flush_vm_context(void)
>  {
>  	dsb(ishst);
> -	asm volatile("tlbi alle1is	\n"
> -		     "ic ialluis	  ": : );
> +	__tlbi(alle1is);
> +	asm volatile("ic ialluis" : : );
>  	dsb(ish);

Should be a separate patch, but this can now be a __flush_icache_all instead
of the open-coded asm.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Christopher Covington <cov@codeaurora.org> - 2017-01-25 17:00 +0100
  Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Christoffer Dall <christoffer.dall@linaro.org> - 2017-01-25 20:50 +0100
    Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Will Deacon <will.deacon@arm.com> - 2017-01-27 15:20 +0100
  Re: [PATCH v4 3/4] arm64: Use __tlbi() macros in KVM code Will Deacon <will.deacon@arm.com> - 2017-01-27 16:20 +0100

csiph-web