Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1568360
| From | Andy Shevchenko <andriy.shevchenko@linux.intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [char-misc-next V3] mei: simplify error handling via devres function. |
| Date | 2017-01-27 14:40 +0100 |
| Message-ID | <t4eUW-4Ja-25@gated-at.bofh.it> (permalink) |
| References | <t3TdM-8u9-11@gated-at.bofh.it> <t49Vh-1J9-23@gated-at.bofh.it> |
| Organization | Intel Finland Oy |
On Fri, 2017-01-27 at 09:15 +0100, Greg Kroah-Hartman wrote: > On Thu, Jan 26, 2017 at 05:16:26PM +0200, Tomas Winkler wrote: > > Use devm_ and pcim_ functions to make error handling > > simpler and code smaller and tidier. > > > > Based on original patch by > > mei: me: use managed functions pcim_* and devm_* > > https://lkml.org/lkml/2016/2/1/339 > > > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> > > Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > V2: Thanks Andy for review, integratd changes: > > 1. Rename devm_mei_me_init back to mei_me_dev_init > > they don't really belong to devm_ namespace. > > 2. Revert pcim irq reservation change. > > 3. Drop setting driver data to NULL on exit. > > 4. Use directly mmio pointer received from pcim_iomap_table > > V3: Remove pci_disable_msi, it is also handled by the system. > > Andy, any objection to this version? Nope, this looks exactly how I would put it! Thanks! -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[char-misc-next V3] mei: simplify error handling via devres function. Tomas Winkler <tomas.winkler@intel.com> - 2017-01-26 15:30 +0100
Re: [char-misc-next V3] mei: simplify error handling via devres function. Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-01-27 09:20 +0100
Re: [char-misc-next V3] mei: simplify error handling via devres function. Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-01-27 14:40 +0100
csiph-web