[PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence.

From	Shailendra Verma <shailendra.v@samsung.com>
Newsgroups	linux.kernel
Subject	[PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence.
Date	2017-01-27 12:30 +0100
Message-ID	<t4cT7-3sv-1@gated-at.bofh.it> (permalink)
References	<t4cT7-3sv-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

of_match_device could return NULL, and so can cause a NULL
pointer dereference later.

Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
---
 drivers/net/ethernet/mediatek/mtk_eth_soc.c |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
index 4a62ffd..4495b7b 100644
--- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
+++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
@@ -2369,6 +2369,10 @@ static int mtk_probe(struct platform_device *pdev)
 	int i;
 
 	match = of_match_device(of_mtk_match, &pdev->dev);
+	if (!match) {
+		dev_err(&pdev->dev, "Error: No device match found\n");
+		return -ENODEV;
+	}
 	soc = (struct mtk_soc_data *)match->data;
 
 	eth = devm_kzalloc(&pdev->dev, sizeof(*eth), GFP_KERNEL);
-- 
1.7.9.5

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. Shailendra Verma <shailendra.v@samsung.com> - 2017-01-27 12:30 +0100
  Re: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-01-27 14:00 +0100
    Re: [PATCH] Net: ethernet: mediatek - Fix possible NULL derefrence. David Miller <davem@davemloft.net> - 2017-01-27 17:30 +0100

csiph-web