Re: [PATCH 04/13] mmc: bcm2835: add bcm2835_check_data_error

From	Gerd Hoffmann <kraxel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/13] mmc: bcm2835: add bcm2835_check_data_error
Date	2017-01-27 11:40 +0100
Message-ID	<t4c6J-2Vw-7@gated-at.bofh.it> (permalink)
References	<t41O1-5cG-3@gated-at.bofh.it> <t41O1-5cG-9@gated-at.bofh.it> <t449b-6GZ-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

  Hi,

> > @@ -1007,15 +1017,7 @@ static void bcm2835_data_irq(struct bcm2835_host *host, u32 intmask)
> >  	if (!host->data)
> >  		return;
> >
> 
> remove this check, !host->data, as well.

There is a comment in the code saying it is needed, here is more
context:

static void bcm2835_data_irq(struct bcm2835_host *host, u32 intmask)
{
	/* There are no dedicated data/space available interrupt
	 * status bits, so it is necessary to use the single shared
	 * data/space available FIFO status bits. It is therefore not
	 * an error to get here when there is no data transfer in
	 * progress.
	 */
	if (!host->data)
		return;

	bcm2835_check_data_error(host, intmask);

cheers,
  Gerd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 04/13] mmc: bcm2835: add bcm2835_check_data_error Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 00:40 +0100
  Re: [PATCH 04/13] mmc: bcm2835: add bcm2835_check_data_error Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-27 03:10 +0100
    Re: [PATCH 04/13] mmc: bcm2835: add bcm2835_check_data_error Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 11:40 +0100

csiph-web