Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel

Path	csiph.com!news.redatomik.org!aioe.org!bofh.it!news.nic.it!robomod
From	Juergen Gross <jgross@suse.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel
Date	Fri, 27 Jan 2017 11:30:01 +0100
Message-ID	<t4bX3-2Sv-3@gated-at.bofh.it> (permalink)
References	<t3WOm-2et-9@gated-at.bofh.it>
X-Original-To	Mohit Gambhir <mohit.gambhir@oracle.com>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
User-Agent	Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0
MIME-Version	1.0
Content-Type	text/plain; charset=utf-8
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Date	Fri, 27 Jan 2017 11:27:48 +0100
X-Original-Message-ID	<a518220e-63f1-0832-e2b0-74e26dd9cf7f@suse.com>
X-Original-References	<fe4a713b-b6c7-bcd2-b5b5-1359532617d6@oracle.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1568025

Show key headers only | View raw

On 26/01/17 19:12, Mohit Gambhir wrote:
> This patch fixes the following warning message seen when booting the
> kernel as Dom0 with Xen on Intel machines.
> 
> [0.003000] [Firmware Bug]: CPU1: APIC id mismatch. Firmware: 0 APIC: 1]
> 
> The code generating the warning in validate_apic_and_package_id() matches
> cpu_data(cpu).apicid (initialized in init_intel()->
> detect_extended_topology() using cpuid) against the apicid returned from
> xen_apic_read(). Now, xen_apic_read() makes a hypercall to retrieve apicid
> for the boot  cpu but returns 0 otherwise. Hence the warning gets thrown
> for all but the boot cpu.
> 
> The idea behind xen_apic_read() returning 0 for apicid is that the
> guests (even Dom0) should not need to know what physical processor their
> vcpus are running on. This is because we currently  do not have topology
> information in Xen and also because xen allows more vcpus than physical
> processors. However, boot cpu's apicid is required for loading
> xen-acpi-processor driver on AMD machines. Look at following patch for
> details:
> 
> commit 558daa289a40 ("xen/apic: Return the APIC ID (and version) for CPU
> 0.")
> 
> So to get rid of the warning, this patch modifies
> xen_cpu_present_to_apicid() to return cpu_data(cpu).apicid instead of
> calling xen_apic_read().
> 
> The warning is not seen on AMD machines because init_amd() populates
> cpu_data(cpu).apicid by calling hard_smp_processor_id()->xen_apic_read()
> as opposed to using apicid from cpuid as is done on Intel machines.
> 
> Signed-off-by: Mohit Gambhir <mohit.gambhir@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>


Thanks,

Juergen

Thread

[PATCH] x86/xen: Fix APIC id mismatch warning on Intel Mohit Gambhir <mohit.gambhir@oracle.com> - 2017-01-26 19:20 +0100
  Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel Juergen Gross <jgross@suse.com> - 2017-01-27 11:30 +0100
  Re: [PATCH] x86/xen: Fix APIC id mismatch warning on Intel Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2017-01-30 04:10 +0100

csiph-web