Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL

Path	csiph.com!news.redatomik.org!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk is NULL
Date	Sat, 28 Jan 2017 14:40:01 +0100
Message-ID	<t4Bot-23o-3@gated-at.bofh.it> (permalink)
References	<siOHn-2YU-5@gated-at.bofh.it> <sAbod-1dk-1@gated-at.bofh.it>
Dkim-Filter	OpenDKIM Filter v2.10.3 conssluserg-02.nifty.com v0SDX9Dx023074
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1485610390; bh=WXgWm96QKqgK4cOimEMtIPTfsjVCVESPcjK4R3aqx1E=; h=In-Reply-To:References:From:Date:Subject:To:Cc:From; b=ituFrd/n3yBTVJdheS0zhb1eaArEcNvHtlu5nLaFaN68qesvfWtClwYM68Sl3YNz7 YyQkS0Ii59Mlv2Y0Ru+2gap/jPQblpSsIfXTIo6vuNoDfVfMbqO2KZxZgZNSUqRjY1 LguzbL7KjwDqpQkPPMQaFLendXrjLZyU+RIDqZUVVjuF/faa7ycM8oxc652UpwNv7g 6vK5A0JsBbv52Nq97+m43BYCsKki83S/G1LLRf4DTyEGByW7K5Y+UWuW+KK86TWj11 mt2v49DzCV4hp3n6shXRZI8c2blUv6iF72vpMoJzE32u/mpS3CXtERFp5QbhfzRb+k qiT0SquEW4aKw==
X-Nifty-Srcip	[209.85.213.180]
X-Gm-Message-State	AIkVDXIZqvlSX2rd1QGRZUIzRtdI5K7igWtERC2uwD40D0StR5iBiq/aNJbzpcgbgll+1TBAwktNiCBOIR8MWA==
X-Received	by 10.37.15.138 with SMTP id 132mr5556140ybp.185.1485610389011; Sat, 28 Jan 2017 05:33:09 -0800 (PST)
MIME-Version	1.0
X-Gmail-Original-Message-ID	<CAK7LNARSu0mZ2RPzDDtD6yqFHeo6cLza7EVT8O_L+vPL3uUc1w@mail.gmail.com>
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	69
Organization	linux.* mail to news gateway
X-Original-Cc	Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Russell King <linux@armlinux.org.uk>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Masahiro Yamada <yamada.masahiro@socionext.com>, Ralf Baechle <ralf@linux-mips.org>
X-Original-Date	Sat, 28 Jan 2017 22:33:08 +0900
X-Original-Message-ID	<CAK7LNARSu0mZ2RPzDDtD6yqFHeo6cLza7EVT8O_L+vPL3uUc1w@mail.gmail.com>
X-Original-References	<1474221526-21195-1-git-send-email-yamada.masahiro@socionext.com> <CAK7LNASn+-HrzwSnrrR3nuGzvmhLzQRTXduSmF1N51uwyzaYTg@mail.gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1568901

Show key headers only | View raw

Hi Eric Miao, Haojian Zhuang,

Ping again.

Please apply this patch!


2016-11-06 0:42 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> Hi Eric Miao, Haojian Zhuang,
>
> Could you pick up this patch, please?
>
>
> 2016-09-19 2:58 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> In many of clk_disable() implementations, it is a no-op for a NULL
>> pointer input, but this is one of the exceptions.
>>
>> Making it treewide consistent will allow clock consumers to call
>> clk_disable() without NULL pointer check.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>> Changes in v4:
>>   - Split into per-arch patches
>>
>> Changes in v3:
>>   - Return only when clk is NULL.  Do not take care of error pointer.
>>
>> Changes in v2:
>>   - Rebase on Linux 4.6-rc1
>>
>>  arch/arm/mach-mmp/clock.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/mach-mmp/clock.c b/arch/arm/mach-mmp/clock.c
>> index ac6633d..28fe64c 100644
>> --- a/arch/arm/mach-mmp/clock.c
>> +++ b/arch/arm/mach-mmp/clock.c
>> @@ -67,6 +67,9 @@ void clk_disable(struct clk *clk)
>>  {
>>         unsigned long flags;
>>
>> +       if (!clk)
>> +               return;
>> +
>>         WARN_ON(clk->enabled == 0);
>>
>>         spin_lock_irqsave(&clocks_lock, flags);
>> --
>> 1.9.1
>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>
>
> --
> Best Regards
> Masahiro Yamada



-- 
Best Regards
Masahiro Yamada

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4] ARM: mmp: let clk_disable() return immediately if clk  is NULL Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-01-28 14:40 +0100

csiph-web