Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567865
| From | Shawn Lin <shawn.lin@rock-chips.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd |
| Date | 2017-01-27 03:10 +0100 |
| Message-ID | <t449b-6GZ-3@gated-at.bofh.it> (permalink) |
| References | <t41O1-5cG-3@gated-at.bofh.it> <t41O2-5cG-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2017/1/27 7:37, Gerd Hoffmann wrote:
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> drivers/mmc/host/bcm2835.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
> index 9744517..ceee4cf 100644
> --- a/drivers/mmc/host/bcm2835.c
> +++ b/drivers/mmc/host/bcm2835.c
> @@ -609,6 +609,36 @@ static void bcm2835_prepare_data(struct bcm2835_host *host,
> writel(data->blocks, host->ioaddr + SDHBLC);
> }
>
> +static u32 bcm2835_read_wait_sdcmd(struct bcm2835_host *host, u32 timeout,
> + bool check_fail)
> +{
> + struct device *dev = &host->pdev->dev;
> + unsigned long start = jiffies;
> + unsigned long fastpoll = start + usecs_to_jiffies(10);
> + unsigned long end = start + msecs_to_jiffies(timeout);
> + u32 value;
> +
> + for (;;) {
> + value = readl(host->ioaddr + SDCMD);
> + if (!(value & SDCMD_NEW_FLAG))
> + break;
> + if (check_fail && (value & SDCMD_FAIL_FLAG))
> + break;
> + if (time_after(jiffies, end)) {
> + dev_err(dev, "%s: timeout (%d us)\n",
> + __func__, timeout);
> + break;
> + }
> +
> + /* if it takes longer reduce poll interval */
> + if (time_after(jiffies, fastpoll))
> + udelay(10);
> + else
> + cpu_relax();
> + }
Use readl_poll_timeout intead of open-coding them..
> + return value;
> +}
> +
> bool bcm2835_send_command(struct bcm2835_host *host,
> struct mmc_command *cmd)
> {
>
--
Best Regards
Shawn Lin
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 00:40 +0100
Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Florian Fainelli <f.fainelli@gmail.com> - 2017-01-27 01:00 +0100
Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 09:10 +0100
Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Florian Fainelli <f.fainelli@gmail.com> - 2017-01-27 19:30 +0100
Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Shawn Lin <shawn.lin@rock-chips.com> - 2017-01-27 03:10 +0100
Re: [PATCH 01/13] mmc: bcm2835: add bcm2835_read_wait_sdcmd Gerd Hoffmann <kraxel@redhat.com> - 2017-01-27 11:50 +0100
csiph-web