[PATCH 07/23] perf tools: Add one liner warning for disabled features

Path	csiph.com!1.us.feeder.erje.net!feeder.erje.net!1.eu.feeder.erje.net!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH 07/23] perf tools: Add one liner warning for disabled features
Date	Wed, 25 Jan 2017 15:00:01 +0100
Message-ID	<t3whb-2sl-3@gated-at.bofh.it> (permalink)
References	<t3whb-2sl-5@gated-at.bofh.it>
X-Mailer	git-send-email 2.9.3
X-Srs-Rewrite	SMTP reverse-path rewritten from <acme@infradead.org> by merlin.infradead.org. See http://www.infradead.org/rpr.html
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	87
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, Andi Kleen <ak@linux.intel.com>, Arnaldo Carvalho de Melo <acme@redhat.com>
X-Original-Date	Wed, 25 Jan 2017 10:53:34 -0300
X-Original-Message-ID	<20170125135350.22983-8-acme@kernel.org>
X-Original-References	<20170125135350.22983-1-acme@kernel.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1566605

Show key headers only | View raw

From: Andi Kleen <ak@linux.intel.com>

Add a one liner warning for perf features that need to be enabled
explicitly by the user, so that they know they are missing something.

Currently enabled for XED and BABELTRACE.

Committer notes:

Testing it:

  $ make O=/tmp/build/perf -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user: XED LIBBABELTRACE
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $
  $ make O=/tmp/build/perf XED=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user:  LIBBABELTRACE
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $
  $ make O=/tmp/build/perf LIBBABELTRACE=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
  Makefile.config:853: Disabled features, need explicit enabling by user:  XED
  CC       /tmp/build/perf/arch/common.o
  <SNIP>
  $
  $ make O=/tmp/build/perf XED=1 LIBBABELTRACE=1 -C tools/perf
  make: Entering directory '/home/acme/git/linux/tools/perf'
    BUILD:   Doing 'make -j4' parallel build
  make: Leaving directory '/home/acme/git/linux/tools/perf'
  $

Signed-off-by: Andi Kleen <ak@linux.intel.com>
Suggested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Link: http://lkml.kernel.org/r/20170103183946.GK27864@kernel.org
Acked-by: Jiri Olsa <jolsa@kernel.org>
Link: http://lkml.kernel.org/r/20170119014150.19218-3-andi@firstfloor.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Makefile.config | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
index fd798d118739..0caa11979279 100644
--- a/tools/perf/Makefile.config
+++ b/tools/perf/Makefile.config
@@ -65,6 +65,8 @@ ifneq ($(ARCH),$(filter $(ARCH),x86 arm))
   NO_LIBDW_DWARF_UNWIND := 1
 endif
 
+DISABLED_FEATURES =
+
 ifeq ($(LIBUNWIND_LIBS),)
   NO_LIBUNWIND := 1
 endif
@@ -701,6 +703,8 @@ ifdef XED
   else
     msg := $(warning No xed found, disables x86 disassembler support, please install xed);
   endif
+else
+  DISABLED_FEATURES += XED
 endif
 
 ifndef NO_LZMA
@@ -775,6 +779,8 @@ ifdef LIBBABELTRACE
   else
     msg := $(warning No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev);
   endif
+else
+  DISABLED_FEATURES += LIBBABELTRACE
 endif
 
 ifndef NO_AUXTRACE
@@ -846,6 +852,10 @@ ifdef LIBCLANGLLVM
   endif
 endif
 
+ifneq ($(DISABLED_FEATURES),)
+  $(warning Disabled features, need explicit enabling by user: $(DISABLED_FEATURES))
+endif
+
 # Among the variables below, these:
 #   perfexecdir
 #   template_dir
-- 
2.9.3

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 07/23] perf tools: Add one liner warning for disabled features Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-25 15:00 +0100

csiph-web