Re: fs/jffs2/readinode.c:189: faulty logic ?

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: fs/jffs2/readinode.c:189: faulty logic ?
Date	2017-01-25 09:40 +0100
Message-ID	<t3rhw-7QP-17@gated-at.bofh.it> (permalink)
References	<t3aJI-5zH-21@gated-at.bofh.it> <t3hLc-1N5-13@gated-at.bofh.it> <t3rhw-7QP-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

David,

Am 24.01.2017 um 23:57 schrieb David Binderman:
>>> fs/jffs2/readinode.c:189]: (style) Condition 'tn.fn.ofs>=offset' is always true
> 
>>What tool produces this info?
> 
> A static analyser for C and C++ called cppcheck, available from sourceforge.

That needs to go into the changelog.

>>That code is odd, yes. But we need more info.
>>Why is fn.fn.ofs>=offset always true?
> 
> Doh. By obvious inspection of the code.
> If test x < y fails, then x must be >= y.

So tn.fn.ofs>=offset is _not_ always true.
The else branch is always false.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: fs/jffs2/readinode.c:189: faulty logic ? Richard Weinberger <richard.weinberger@gmail.com> - 2017-01-24 23:30 +0100
  Re: fs/jffs2/readinode.c:189: faulty logic ? Richard Weinberger <richard@nod.at> - 2017-01-25 09:40 +0100

csiph-web