Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566393

Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags

Show all headers | View raw

And yes I did. Somehow managed to ignore those warnings though, sorry
about that.
Rechecked with just first patch and it should still be good. Please
ignore this one ;)

On 24 January 2017 at 16:44, Johannes Berg <johannes@sipsolutions.net> wrote:
> On Tue, 2017-01-24 at 16:42 +0100, Amadeusz Sławiński wrote:
>> cleanup patch to make use of set_sta_flag()/clear_sta_flag() in
>> places
>> where we access sta->_flags
>>
>> Signed-off-by: Amadeusz Sławiński <amadeusz.slawinski@tieto.com>
>> ---
>>  net/mac80211/sta_info.c | 12 ++++++------
>>  1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
>> index b6cfcf0..6c9cc2f 100644
>> --- a/net/mac80211/sta_info.c
>> +++ b/net/mac80211/sta_info.c
>> @@ -1855,13 +1855,13 @@ int sta_info_move_state(struct sta_info *sta,
>>       switch (new_state) {
>>       case IEEE80211_STA_NONE:
>>               if (sta->sta_state == IEEE80211_STA_AUTH)
>> -                     clear_bit(WLAN_STA_AUTH, &sta->_flags);
>> +                     clear_sta_flag(sta, WLAN_STA_AUTH);
>
> You should try to run this patch sometime :)
>
> johannes

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] mac80211: use helper function to access ieee802_1d_to_ac[] Amadeusz Sławiński          <amadeusz.slawinski@tieto.com> - 2017-01-24 16:50 +0100
  Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags Johannes Berg <johannes@sipsolutions.net> - 2017-01-24 16:50 +0100
    Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags Amadeusz Slawinski <amadeusz.slawinski@tieto.com> - 2017-01-25 10:00 +0100
      Re: [PATCH 2/2] mac80211: use accessor functions to set sta->_flags Johannes Berg <johannes@sipsolutions.net> - 2017-01-25 10:20 +0100
  [PATCH 2/2] mac80211: use accessor functions to set sta->_flags Amadeusz Sławiński          <amadeusz.slawinski@tieto.com> - 2017-01-24 16:50 +0100
  Re: [PATCH 1/2] mac80211: use helper function to access  ieee802_1d_to_ac[] Johannes Berg <johannes@sipsolutions.net> - 2017-01-26 10:00 +0100

csiph-web