Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566362
| Path | csiph.com!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Clemens Ladisch <clemens@ladisch.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [alsa-devel] [PATCH 6/7] dmasound_core: Move two assignments for the variable "ret" in state_open() |
| Date | Wed, 25 Jan 2017 08:50:01 +0100 |
| Message-ID | <t3qv7-7jU-3@gated-at.bofh.it> (permalink) |
| References | <t36wq-34u-3@gated-at.bofh.it> <t36wr-34u-43@gated-at.bofh.it> |
| X-Greylist | delayed 383 seconds by postgrey-1.27 at vger.kernel.org; Wed, 25 Jan 2017 02:47:39 EST |
| User-Agent | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Transfer-Encoding | 7bit |
| X-Virus-Status | Clean |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 18 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Jaroslav Kysela <perex@perex.cz>, Martin Koegler <martin.koegler@chello.at>, Takashi Iwai <tiwai@suse.com>, Takashi Sakamoto <o-takashi@sakamocchi.jp>, kernel-janitors@vger.kernel.org, LKML <linux-kernel@vger.kernel.org> |
| X-Original-Date | Wed, 25 Jan 2017 08:40:27 +0100 |
| X-Original-Message-ID | <5701efac-3c37-8b6c-fbe7-89a54e988998@ladisch.de> |
| X-Original-References | <f2404d64-27c8-4afa-b893-fc72601c0136@users.sourceforge.net> <b4d0b274-23ac-4369-7119-a77e5108578b@users.sourceforge.net> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1566362 |
Show key headers only | View raw
SF Markus Elfring wrote:
> A local variable was set to an error code in two cases before a concrete
> error situation was detected.
And why would that be a problem?
http://yarchive.net/comp/linux/error_jumps.html
> - ret = -EBUSY;
> - if (state.busy)
> + if (state.busy) {
> + ret = -EBUSY;
> goto out;
> + }
Regards,
Clemens
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] ALSA: Fine-tuning for several function implementations SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
[PATCH 7/7] dmasound_core: Adjust six function calls together with a variable assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
[PATCH 2/7] ALSA: seq: Delete unnecessary checks in snd_seq_ioctl_get_subscription() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
[PATCH 1/7] ALSA: seq: Delete unnecessary checks in snd_seq_ioctl_query_subs() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
[PATCH 6/7] dmasound_core: Move two assignments for the variable "ret" in state_open() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
Re: [alsa-devel] [PATCH 6/7] dmasound_core: Move two assignments for the variable "ret" in state_open() Clemens Ladisch <clemens@ladisch.de> - 2017-01-25 08:50 +0100
[PATCH 5/7] ALSA: seq: Adjust 16 function calls together with a variable assignment SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
[PATCH 4/7] ALSA: seq: Delete unnecessary checks in snd_seq_ioctl_subscribe_port() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-01-24 11:30 +0100
csiph-web