Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566357

Re: [PATCH 2/2] perf tools: Introduce regs_query_register_offset() for arm64

Show all headers | View raw

hi

在 2017/1/25 3:09, Arnaldo Carvalho de Melo 写道:
> Em Tue, Jan 24, 2017 at 06:25:18PM +0000, Will Deacon escreveu:
>> On Tue, Jan 24, 2017 at 10:30:15AM +0000, He Kuang wrote:
>>> Since HAVE_KPROBES can be enabled in arm64, this patch introduces
>>> regs_query_register_offset() to convert register name to offset for
>>> arm64, so the BPF prologue feature is ready to use.
>>>
>>> This patch also changes the 'dwarfnum' to 'offset' in register table,
>>> so the related functions are consistent with x86.
>>>
>>> Signed-off-by: He Kuang <hekuang@huawei.com>
>   
>> It would've been nice to have been cc'd on this. In future, please at least
>> cc linux-arm-kernel for patches directly changing arm/arm64 code.
>   
>>> +	GPR_OFFSET_NAME(30),
>>> +	{.name = "lr", .offset = offsetof(struct user_pt_regs, regs[30])},
>>> +	REG_OFFSET_NAME(sp),
>   
>> Don't sp and lr need the leading '%'?
>   
>>> +	REG_OFFSET_NAME(pc),
>>> +	REG_OFFSET_NAME(pstate),
>   
>> The AArch64 DWARF spec says that DWARF register 32 is "RESERVED" and
>> register 33 is the ELR, so these pc/pstate entries are wrong.
>   
>> However, with those changes, I think this patch can simply be ignored and
>> mainline is doing the right thing.
> Ok, thanks for checking, dropping this patch then.
>
> - Arnaldo
>

The purpose of this patch is mainly on enable bpf prologue on arm64,
a new v2 version is sent and fix the problem mentioned by Will, thank
you for reviewing this.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] Support bpf prologue for arm64 He Kuang <hekuang@huawei.com> - 2017-01-24 11:40 +0100
  [PATCH 2/2] perf tools: Introduce regs_query_register_offset() for arm64 He Kuang <hekuang@huawei.com> - 2017-01-24 11:40 +0100
    Re: [PATCH 2/2] perf tools: Introduce regs_query_register_offset()  for arm64 Will Deacon <will.deacon@arm.com> - 2017-01-24 19:30 +0100
      Re: [PATCH 2/2] perf tools: Introduce regs_query_register_offset()  for arm64 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-24 20:10 +0100
        Re: [PATCH 2/2] perf tools: Introduce regs_query_register_offset()  for arm64 Hekuang <hekuang@huawei.com> - 2017-01-25 08:30 +0100
        [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 He Kuang <hekuang@huawei.com> - 2017-01-25 08:30 +0100
          Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 Will Deacon <will.deacon@arm.com> - 2017-01-25 14:40 +0100
            Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 Masami Hiramatsu <mhiramat@kernel.org> - 2017-01-26 02:50 +0100
              Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 Will Deacon <will.deacon@arm.com> - 2017-01-26 18:10 +0100
                Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-26 20:40 +0100
          Re: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 Masami Hiramatsu <mhiramat@kernel.org> - 2017-01-26 03:00 +0100
  [PATCH 1/2] perf probe: Fix wrong register name for arm64 He Kuang <hekuang@huawei.com> - 2017-01-24 11:40 +0100
    Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-24 20:20 +0100
      Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64 Will Deacon <will.deacon@arm.com> - 2017-01-25 10:30 +0100
    Re: [PATCH 1/2] perf probe: Fix wrong register name for arm64 Masami Hiramatsu <mhiramat@kernel.org> - 2017-01-26 02:30 +0100
    [tip:perf/core] perf probe: Fix wrong register name for arm64 tip-bot for He Kuang <tipbot@zytor.com> - 2017-01-26 16:40 +0100
  Re: [PATCH 0/2] Support bpf prologue for arm64 Arnaldo Carvalho de Melo <acme@kernel.org> - 2017-01-24 17:00 +0100

csiph-web