Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566293

Re: [PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver for ZTE's zx2967 family

Show all headers | View raw

On 01/24/2017 06:16 PM, Baoyou Xie wrote:
>
[ ... ]
>         +
>         +       ret = of_parse_phandle_with_fixed_args(dev->of_node,
>         +                       "zte,wdt-reset-sysctrl", 3, 0, &out_args);
>         +       if (ret)
>         +               return;
>         +
>         +       offset = out_args.args[0];
>         +       config = out_args.args[1];
>         +       mask = out_args.args[2];
>         +
>         +       regmap = syscon_node_to_regmap(out_args.np <http://out_args.np>);
>         +       if (IS_ERR(regmap))
>         +               return;
>         +
>         +       regmap_update_bits(regmap, offset, mask, config);
>
>
>     Another comment suggested adding
>             of_node_put(out_args.np <http://out_args.np>);
>     here.
>
>
> is it really? most of the driver that call this function don't call of_node_put. but it seems harmless to call of_node_put.
>
>
Even if everyone else is doing things wrong, that doesn't mean
that you should do the same, nor is it a good idea to use it
as argument.

Guenter

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver for ZTE's zx2967 family Baoyou Xie <baoyou.xie@linaro.org> - 2017-01-24 10:00 +0100
  Re: [PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver  for ZTE's zx2967 family Guenter Roeck <linux@roeck-us.net> - 2017-01-24 16:00 +0100
    Re: [PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver  for ZTE's zx2967 family Guenter Roeck <linux@roeck-us.net> - 2017-01-25 03:50 +0100
  Re: [PATCH v5 3/3] watchdog: zx2967: add watchdog controller driver  for ZTE's zx2967 family Mathieu Poirier <mathieu.poirier@linaro.org> - 2017-01-24 17:20 +0100

csiph-web