Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566271

Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances, not available_instance

Show all headers | View raw

On 01/25/2017 03:53 AM, Alex Williamson wrote:
> Per the ABI specification[1], each mdev_supported_types entry should
> have an available_instances, with an "s", not available_instance.
> 
> [1] Documentation/ABI/testing/sysfs-bus-vfio-mdev
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
> 
> This should really be fixed before initial release in v4.10

Acked-by: Jike Song <jike.song@intel.com>

Thanks for finding this!


--
Thanks,
Jike

> 
>  drivers/gpu/drm/i915/gvt/kvmgt.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gvt/kvmgt.c b/drivers/gpu/drm/i915/gvt/kvmgt.c
> index faaae07..ab1e057 100644
> --- a/drivers/gpu/drm/i915/gvt/kvmgt.c
> +++ b/drivers/gpu/drm/i915/gvt/kvmgt.c
> @@ -230,8 +230,8 @@ static struct intel_vgpu_type *intel_gvt_find_vgpu_type(struct intel_gvt *gvt,
>  	return NULL;
>  }
>  
> -static ssize_t available_instance_show(struct kobject *kobj, struct device *dev,
> -		char *buf)
> +static ssize_t available_instances_show(struct kobject *kobj,
> +					struct device *dev, char *buf)
>  {
>  	struct intel_vgpu_type *type;
>  	unsigned int num = 0;
> @@ -269,12 +269,12 @@ static ssize_t description_show(struct kobject *kobj, struct device *dev,
>  				type->fence);
>  }
>  
> -static MDEV_TYPE_ATTR_RO(available_instance);
> +static MDEV_TYPE_ATTR_RO(available_instances);
>  static MDEV_TYPE_ATTR_RO(device_api);
>  static MDEV_TYPE_ATTR_RO(description);
>  
>  static struct attribute *type_attrs[] = {
> -	&mdev_type_attr_available_instance.attr,
> +	&mdev_type_attr_available_instances.attr,
>  	&mdev_type_attr_device_api.attr,
>  	&mdev_type_attr_description.attr,
>  	NULL,
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances,  not available_instance Alex Williamson <alex.williamson@redhat.com> - 2017-01-24 21:00 +0100
  Re: [PATCH] drm/i915/gvt/kvmgt: mdev ABI is available_instances,  not available_instance Jike Song <jike.song@intel.com> - 2017-01-25 03:00 +0100
  Re: [igvt-g-dev] [PATCH] drm/i915/gvt/kvmgt: mdev ABI is  available_instances, not available_instance Zhenyu Wang <zhenyuw@linux.intel.com> - 2017-01-25 03:30 +0100

csiph-web