Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1566141

Re: [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY embedded in the topaz switch

From Gregory CLEMENT <gregory.clement@free-electrons.com>
Newsgroups linux.kernel
Subject Re: [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY embedded in the topaz switch
Date 2017-01-24 22:00 +0100
Message-ID <t3gm7-DC-41@gated-at.bofh.it> (permalink)
References <t3fJn-po-15@gated-at.bofh.it> <t3fJs-po-137@gated-at.bofh.it> <t3fT4-sV-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Andrew,
 
 On mar., janv. 24 2017, Andrew Lunn <andrew@lunn.ch> wrote:

> On Tue, Jan 24, 2017 at 09:10:26PM +0100, Gregory CLEMENT wrote:
>> The PHY with the ID 0x1410C00
>
> :-(
>
> I don't have a better reference, but
> Linux/Documentation/devicetree/bindings/net/phy.txt says:
>
>  22   If the phy's identifier is known then the list may contain an entry
>  23   of the form: "ethernet-phy-idAAAA.BBBB" where
>  24      AAAA - The value of the 16 bit Phy Identifier 1 register as
>  25             4 hex digits. This is the chip vendor OUI bits 3:18
>  26      BBBB - The value of the 16 bit Phy Identifier 2 register as
>  27             4 hex digits. This is the chip vendor OUI bits 19:24,
>  28             followed by 10 bits of a vendor specific ID.
>
> So the lower 10 bits of 0x1410C00 are 0. So we know it is a Marvell
> PHY from the OUI, but the vendor specific bits are all 0.

In your previous email you mention a value of 0x01410000, so when I saw
the "C00" at the end I was happy and I didn't look for further.

>
> Please take a look at:
>
> https://marc.info/?l=linux-netdev&m=148495522620757&w=1
>
> and
>
> https://marc.info/?l=linux-netdev&m=148495510320714&w=1
>
> Maybe i should submit these two independently, so you can extend it
> for the 88E6341 family.

Please do it :)

The feedback from Florian and Vivian was good about it so I see no
reason to not apply them.

Add me in CC so I will now when to rebase my series.

Thanks,

Gregory

>
>     Andrew

-- 
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next v6 0/4] Add support for the ethernet switch on the ESPRESSObin Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:20 +0100
  [PATCH net-next v6 1/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:20 +0100
    Re: [PATCH net-next v6 1/4] net: dsa: mv88e6xxx: Don't forbid MDIO I/Os for PHY addr >= num_of_ports Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:40 +0100
  [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:20 +0100
    Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for  ethernet switch 88E6341 Andrew Lunn <andrew@lunn.ch> - 2017-01-25 03:10 +0100
      Re: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6341 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-25 09:00 +0100
        RE: [PATCH net-next v6 2/4] net: dsa: mv88e6xxx: Add support for  ethernet switch 88E6341 Jon Pannell <jpannell@marvell.com> - 2017-01-25 20:10 +0100
  [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY embedded in the topaz switch Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:20 +0100
    Re: [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY  embedded in the topaz switch Andrew Lunn <andrew@lunn.ch> - 2017-01-24 21:30 +0100
      Re: [PATCH net-next v6 4/4] phy: marvell: Add support for the PHY embedded in the topaz switch Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 22:00 +0100
  [PATCH net-next v6 3/4] net: dsa: mv88e6xxx: Add support for ethernet switch 88E6141 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2017-01-24 21:20 +0100

csiph-web