Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566139

Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k
Date 2017-01-24 22:00 +0100
Message-ID <t3gm7-DC-25@gated-at.bofh.it> (permalink)
References <t3fq4-8tN-79@gated-at.bofh.it> <t3fJn-po-13@gated-at.bofh.it> <t3gcq-zS-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Tue, 24 Jan 2017 22:45:37 +0200

> On Tue, Jan 24, 2017 at 03:09:59PM -0500, David Miller wrote:
>> From: "Michael S. Tsirkin" <mst@redhat.com>
>> Date: Tue, 24 Jan 2017 21:53:13 +0200
>> 
>> > I didn't realise. Why can't we? I thought that adjust_header is an
>> > optional feature that userspace can test for, so no rush.
>> 
>> No, we want the base set of XDP features to be present in all drivers
>> supporting XDP.
> 
> I see, I didn't realize this. In light of this, is there any
> guidance *how much* head room is required to be considered
> valid? We already have 12 bytes of headroom.

The idea is to allow programs to implement arbitrary kinds of
encapsulation, so we need to be able to allow them to push headers for
all kinds of software tunnels, with allowance for a few depths in some
extreme cases.

In that light, a nice round power of 2 number such as 256 seems quite
reasonable to me.

This seems to be what other XDP implementations in drivers use at the
moment as well.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] virtio_net: fix PAGE_SIZE > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-23 20:40 +0100
  Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k David Miller <davem@davemloft.net> - 2017-01-24 20:50 +0100
    Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-24 21:00 +0100
      Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k David Miller <davem@davemloft.net> - 2017-01-24 21:20 +0100
        Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-24 21:50 +0100
          Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k David Miller <davem@davemloft.net> - 2017-01-24 22:00 +0100
            Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-24 22:10 +0100
              Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k David Miller <davem@davemloft.net> - 2017-01-24 22:20 +0100
                Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k "Michael S. Tsirkin" <mst@redhat.com> - 2017-01-24 23:00 +0100
                Re: [PATCH v2] virtio_net: fix PAGE_SIZE > 64k John Fastabend <john.fastabend@gmail.com> - 2017-01-25 04:50 +0100

csiph-web