Re: [PATCH] phy: marvell: remove conflicting initializer

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] phy: marvell: remove conflicting initializer
Date	2017-01-24 20:10 +0100
Message-ID	<t3eDD-8cr-1@gated-at.bofh.it> (permalink)
References	<t2LLk-6l3-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Arnd Bergmann <arnd@arndb.de>
Date: Mon, 23 Jan 2017 13:18:41 +0100

> One line was apparently pasted incorrectly during a new feature patch:
> 
> drivers/net/phy/marvell.c:2090:15: error: initialized field overwritten [-Werror=override-init]
>    .features = PHY_GBIT_FEATURES,
> 
> I'm removing the extraneous line here to avoid the W=1 warning and restore
> the previous flags value, and I'm slightly reordering the lines for consistency
> to make it less likely to happen again in the future. The ordering in the
> array is still not the same as in the structure definition, instead I picked
> the order that is most common in this file and that seems to make more sense
> here.
> 
> Fixes: 0b04680fdae4 ("phy: marvell: Add support for temperature sensor")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied, thanks Arnd.

Please start putting appropriate "net" and "net-next" strings in your
PATCH subject lines, it will save me a lot of time.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: marvell: remove conflicting initializer Arnd Bergmann <arnd@arndb.de> - 2017-01-23 13:20 +0100
  Re: [PATCH] phy: marvell: remove conflicting initializer Andrew Lunn <andrew@lunn.ch> - 2017-01-23 16:20 +0100
    Re: [PATCH] phy: marvell: remove conflicting initializer Arnd Bergmann <arnd@arndb.de> - 2017-01-23 17:20 +0100
      Re: [PATCH] phy: marvell: remove conflicting initializer Andrew Lunn <andrew@lunn.ch> - 2017-01-23 17:30 +0100
  Re: [PATCH] phy: marvell: remove conflicting initializer David Miller <davem@davemloft.net> - 2017-01-24 20:10 +0100

csiph-web