Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1566030
| From | Alexei Starovoitov <alexei.starovoitov@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] bpf: don't kfree an uninitialized im_node |
| Date | 2017-01-24 19:00 +0100 |
| Message-ID | <t3dxU-7k1-7@gated-at.bofh.it> (permalink) |
| References | <t3a6Z-5lN-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Jan 24, 2017 at 6:16 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are some error exit paths to the label 'out' that end up
> kfree'ing an uninitialized im_node. Fix this by inititializing
> im_node to NULL to avoid kfree'ing a garbage address.
this fix already landed. See:
commit d140199af510 ("bpf, lpm: fix kfree of im_node in trie_update_elem")
> Issue found by CoverityScan, CID#1398022 ("Uninitialized pointer read")
Nice. Good to know that static analysis can do such checks.
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] bpf: don't kfree an uninitialized im_node Colin King <colin.king@canonical.com> - 2017-01-24 15:20 +0100 Re: [PATCH] bpf: don't kfree an uninitialized im_node Alexei Starovoitov <alexei.starovoitov@gmail.com> - 2017-01-24 19:00 +0100
csiph-web