Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1566023

[PATCH 1/2] staging: lustre: libcfs: use octal permissions

From Ernestas Kulik <ernestas.kulik@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 1/2] staging: lustre: libcfs: use octal permissions
Date 2017-01-24 18:50 +0100
Message-ID <t3dod-7gJ-5@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Using octal permissions instead of symbolic ones is preferred.

Signed-off-by: Ernestas Kulik <ernestas.kulik@gmail.com>
---
 drivers/staging/lustre/lnet/libcfs/module.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lnet/libcfs/module.c b/drivers/staging/lustre/lnet/libcfs/module.c
index 161e04226521..c388550c2d10 100644
--- a/drivers/staging/lustre/lnet/libcfs/module.c
+++ b/drivers/staging/lustre/lnet/libcfs/module.c
@@ -488,10 +488,10 @@ static const struct file_operations lnet_debugfs_file_operations_wo = {
 
 static const struct file_operations *lnet_debugfs_fops_select(umode_t mode)
 {
-	if (!(mode & S_IWUGO))
+	if (!(mode & 0222))
 		return &lnet_debugfs_file_operations_ro;
 
-	if (!(mode & S_IRUGO))
+	if (!(mode & 0444))
 		return &lnet_debugfs_file_operations_wo;
 
 	return &lnet_debugfs_file_operations_rw;
-- 
2.11.0

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] staging: lustre: libcfs: use octal permissions Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-01-24 18:50 +0100
  [PATCH 2/2] staging: lustre: llite: use octal permissions Ernestas Kulik <ernestas.kulik@gmail.com> - 2017-01-24 18:50 +0100
  Re: [PATCH 1/2] staging: lustre: libcfs: use octal permissions "Dilger, Andreas" <andreas.dilger@intel.com> - 2017-01-24 23:30 +0100
    Re: [PATCH 1/2] staging: lustre: libcfs: use octal permissions Joe Perches <joe@perches.com> - 2017-01-25 03:30 +0100

csiph-web