Re: [PATCH net-next v5] bridge: multicast to unicast

From	Stephen Hemminger <stephen@networkplumber.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next v5] bridge: multicast to unicast
Date	2017-01-24 19:20 +0100
Message-ID	<t3dRg-7Ga-29@gated-at.bofh.it> (permalink)
References	<t2a93-8g5-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 21 Jan 2017 21:01:32 +0100
Linus Lüssing <linus.luessing@c0d3.blue> wrote:

> @@ -726,12 +729,32 @@ struct net_bridge_port_group *br_multicast_new_port_group(
>  	hlist_add_head(&p->mglist, &port->mglist);
>  	setup_timer(&p->timer, br_multicast_port_group_expired,
>  		    (unsigned long)p);
> +
> +	if (src)
> +		memcpy(p->eth_addr, src, ETH_ALEN);
> +	else
> +		memset(p->eth_addr, 0xff, ETH_ALEN);
> +
>  	return p;
>  }

Maybe use ether_addr_copy here, but is not performance critical

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next v5] bridge: multicast to unicast Linus Lüssing <linus.luessing@c0d3.blue> - 2017-01-21 21:10 +0100
  Re: [PATCH net-next v5] bridge: multicast to unicast Nikolay Aleksandrov <nikolay@cumulusnetworks.com> - 2017-01-21 23:40 +0100
  Re: [PATCH net-next v5] bridge: multicast to unicast David Miller <davem@davemloft.net> - 2017-01-24 18:50 +0100
  Re: [PATCH net-next v5] bridge: multicast to unicast Stephen Hemminger <stephen@networkplumber.org> - 2017-01-24 19:20 +0100
  Re: [PATCH net-next v5] bridge: multicast to unicast Stephen Hemminger <stephen@networkplumber.org> - 2017-01-24 19:20 +0100

csiph-web