[PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page()

From	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page()
Date	2017-01-26 22:30 +0100
Message-ID	<t3ZMe-3YK-11@gated-at.bofh.it> (permalink)
References	<t3ZMe-3YK-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

EREMOVE fails on non-EPC page or when a SECS page with children is to be
removed. These do not happen if the driver is working correctly. Log the
error but do not crash the driver.

Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
---
 drivers/platform/x86/intel_sgx_page_cache.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/intel_sgx_page_cache.c b/drivers/platform/x86/intel_sgx_page_cache.c
index d073057..7f73ac7 100644
--- a/drivers/platform/x86/intel_sgx_page_cache.c
+++ b/drivers/platform/x86/intel_sgx_page_cache.c
@@ -551,10 +551,8 @@ void sgx_free_page(struct sgx_epc_page *entry,
 		ret = __eremove(epc);
 		sgx_put_epc_page(epc);
 
-		if (ret) {
-			pr_err("EREMOVE returned %d\n", ret);
-			BUG();
-		}
+		if (ret)
+			sgx_err(encl, "EREMOVE returned %d\n", ret);
 	}
 
 	spin_lock(&sgx_free_list_lock);
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-26 22:30 +0100
  Re: [PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page() Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-27 16:50 +0100
    Re: [PATCH 1/3] intel_sgx: do not use BUG() in sgx_free_page() Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2017-01-29 16:20 +0100

csiph-web