Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567680

Re: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks

Show all headers | View raw

On Thu, Jan 26, 2017 at 09:33:52AM +0100, Marek Szyprowski wrote:
> Exynos LPASS requires some clocks to be enabled to make any access to its
> registers. This patch adds code for handling such clocks. For current set
> of registers it is enough to keep sfr0_ctrl clock enabled. Till now it
> worked only because those clocks were enabled by bootloader and driver
> probe() happened before they were disabled by clock core because of lack
> of users. Handling those clocks is also needed to make it possible to
> enable support for audio power domain.
> 
> This patch requires adding sfr0_ctrl clock to device tree.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  .../devicetree/bindings/mfd/samsung,exynos5433-lpass.txt       |  6 ++++++
>  drivers/mfd/exynos-lpass.c                                     | 10 ++++++++++
>  2 files changed, 16 insertions(+)
>

Thanks for changes. Looks good now.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:40 +0100
  [PATCH v2 1/8] soc: samsung: pmu: Add dummy support for Exynos5433 SoC Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:40 +0100
    Re: [PATCH v2 1/8] soc: samsung: pmu: Add dummy support for  Exynos5433 SoC Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-26 21:00 +0100
  [PATCH v2 2/8] pinctrl: samsung: Ensure that pad retention is disabled  on driver init Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:40 +0100
  [PATCH v2 8/8] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:40 +0100
  [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:40 +0100
    Re: [PATCH v2 6/8] mfd: exynos-lpass: Add support for clocks Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-26 21:20 +0100
  Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 11:00 +0100
    Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 11:40 +0100
    Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-26 15:40 +0100
      Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 18:00 +0100
  Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-27 20:50 +0100
    Re: [PATCH v2 0/8] Pad retentions support for Exynos5433 Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-30 11:10 +0100

csiph-web