Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1567570
| From | Cyrille Pitchen <cyrille.pitchen@atmel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v3 10/12] crypto: atmel-aes: fix atmel_aes_handle_queue() |
| Date | 2017-01-26 17:20 +0100 |
| Message-ID | <t3UWe-16V-17@gated-at.bofh.it> (permalink) |
| References | <t3UMy-13x-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
This patch fixes the value returned by atmel_aes_handle_queue(), which could have been wrong previously when the crypto request was started synchronously but became asynchronous during the ctx->start() call. Signed-off-by: Cyrille Pitchen <cyrille.pitchen@atmel.com> --- drivers/crypto/atmel-aes.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c index 0e3d0d655b96..9fd2f63b8bc0 100644 --- a/drivers/crypto/atmel-aes.c +++ b/drivers/crypto/atmel-aes.c @@ -879,6 +879,7 @@ static int atmel_aes_handle_queue(struct atmel_aes_dev *dd, struct crypto_async_request *areq, *backlog; struct atmel_aes_base_ctx *ctx; unsigned long flags; + bool start_async; int err, ret = 0; spin_lock_irqsave(&dd->lock, flags); @@ -904,10 +905,12 @@ static int atmel_aes_handle_queue(struct atmel_aes_dev *dd, dd->areq = areq; dd->ctx = ctx; - dd->is_async = (areq != new_areq); + start_async = (areq != new_areq); + dd->is_async = start_async; + /* WARNING: ctx->start() MAY change dd->is_async. */ err = ctx->start(dd); - return (dd->is_async) ? ret : err; + return (start_async) ? ret : err; } -- 2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 00/12] crypto: atmel-authenc: add support to authenc(hmac(shaX),Y(aes)) modes Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:10 +0100 [PATCH v3 09/12] crypto: atmel-sha: add support to hmac(shaX) Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 04/12] crypto: atmel-sha: redefine SHA_FLAGS_SHA* flags to match SHA_MR_ALGO_SHA* Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 06/12] crypto: atmel-sha: add SHA_MR_MODE_IDATAR0 Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 01/12] crypto: atmel-sha: create function to get an Atmel SHA device Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 10/12] crypto: atmel-aes: fix atmel_aes_handle_queue() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 12/12] crypto: atmel-sha: add verbose debug facilities to print hw register names Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 05/12] crypto: atmel-sha: add atmel_sha_wait_for_data_ready() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 03/12] crypto: atmel-sha: make atmel_sha_done_task more generic Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 02/12] crypto: atmel-sha: update request queue management to make it more generic Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 11/12] crypto: atmel-authenc: add support to authenc(hmac(shaX),Y(aes)) modes Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 07/12] crypto: atmel-sha: add atmel_sha_cpu_start() Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100 [PATCH v3 08/12] crypto: atmel-sha: add simple DMA transfers Cyrille Pitchen <cyrille.pitchen@atmel.com> - 2017-01-26 17:20 +0100
csiph-web