Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards
Date	2017-01-26 11:20 +0100
Message-ID	<t3PjQ-65h-33@gated-at.bofh.it> (permalink)
References	<t1tnr-7pp-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jan 19, 2017 at 11:23 PM, Sudip Mukherjee
<sudipm.mukherjee@gmail.com> wrote:

> From: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>
>
> Exar XR17V352/354/358 chips have 16 multi-purpose inputs/outputs which
> can be controlled using gpio interface.
>
> Add the gpio specific code.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk>

Patch applied.

I think maybe we can simplify the patch even more using
select GPIO_GENERIC and just specify the different
registers to bgpio_init().

But that can be done as a separate improvement patch, this
definately looks fine.

Maybe you also want something like:

default SERIAL_8250_EXAR

so that the module is by default added as "y" or "m" depending
on what is selected for the parent device?

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v10 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-19 23:30 +0100
  [PATCH v10 3/3] serial: 8250_pci: remove exar code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-19 23:30 +0100
    Re: [PATCH v10 3/3] serial: 8250_pci: remove exar code Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-20 23:40 +0100
  [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-19 23:30 +0100
    Re: [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-20 23:30 +0100
      Re: [PATCH v10 2/3] serial: exar: split out the exar code from 8250_pci Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-21 01:00 +0100
  Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-01-20 23:20 +0100
    Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2017-01-21 01:00 +0100
      Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 11:20 +0100
  Re: [PATCH v10 1/3] gpio: exar: add gpio for exar cards Linus Walleij <linus.walleij@linaro.org> - 2017-01-26 11:20 +0100

csiph-web