Re: [PATCH 09/12] mm, uprobes: convert __replace_page() to page_check_walk()

From	Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 09/12] mm, uprobes: convert __replace_page() to page_check_walk()
Date	2017-01-26 04:10 +0100
Message-ID	<t3IBH-21F-1@gated-at.bofh.it> (permalink)
References	<t3c8O-6zx-3@gated-at.bofh.it> <t3ciu-6CQ-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

* Kirill A. Shutemov <kirill.shutemov@linux.intel.com> [2017-01-24 19:28:21]:

> For consistency, it worth converting all page_check_address() to
> page_check_walk(), so we could drop the former.
> 
> Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> ---
>  kernel/events/uprobes.c | 22 ++++++++++++++--------
>  1 file changed, 14 insertions(+), 8 deletions(-)
> 
> diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c
> index 1e65c79e52a6..6dbaa93b22fa 100644
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -153,14 +153,19 @@ static int __replace_page(struct vm_area_struct *vma, unsigned long addr,
>  				struct page *old_page, struct page *new_page)
>  {
>  	struct mm_struct *mm = vma->vm_mm;

I thought the subject is a bit misleading, it looks as if we are
replacing __replace_page. Can it be changed to
"Convert __replace_page() to use page_check_walk()" ?

Otherwise looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 00/12] Fix few rmap-related THP bugs "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:30 +0100
  [PATCH 11/12] mm: drop page_check_address{,_transhuge} "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:30 +0100
  [PATCH 12/12] mm: convert remove_migration_pte() to page_check_walk() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:30 +0100
    Re: [PATCH 12/12] mm: convert remove_migration_pte() to  page_check_walk() kbuild test robot <lkp@intel.com> - 2017-01-25 02:50 +0100
  [PATCH 01/12] uprobes: split THPs before trying replace them "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:40 +0100
    Re: [PATCH 01/12] uprobes: split THPs before trying replace them Rik van Riel <riel@redhat.com> - 2017-01-24 19:10 +0100
    Re: [PATCH 01/12] uprobes: split THPs before trying replace them Andrew Morton <akpm@linux-foundation.org> - 2017-01-24 22:30 +0100
      Re: [PATCH 01/12] uprobes: split THPs before trying replace them "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-24 23:30 +0100
        Re: [PATCH 01/12] uprobes: split THPs before trying replace them Andrew Morton <akpm@linux-foundation.org> - 2017-01-24 23:40 +0100
          Re: [PATCH 01/12] uprobes: split THPs before trying replace them "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-25 00:00 +0100
        Re: [PATCH 01/12] uprobes: split THPs before trying replace them Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2017-01-25 18:00 +0100
          Re: [PATCH 01/12] uprobes: split THPs before trying replace them Rik van Riel <riel@redhat.com> - 2017-01-25 18:50 +0100
          Re: [PATCH 01/12] uprobes: split THPs before trying replace them "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-25 18:50 +0100
          Re: [PATCH 01/12] uprobes: split THPs before trying replace them Johannes Weiner <hannes@cmpxchg.org> - 2017-01-25 19:40 +0100
            Re: [PATCH 01/12] uprobes: split THPs before trying replace them "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-25 19:40 +0100
            Re: [PATCH 01/12] uprobes: split THPs before trying replace them Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2017-01-26 04:00 +0100
    Re: [PATCH 01/12] uprobes: split THPs before trying replace them Johannes Weiner <hannes@cmpxchg.org> - 2017-01-25 19:30 +0100
  [PATCH 04/12] mm: fix handling PTE-mapped THPs in page_idle_clear_pte_refs() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:40 +0100
  [PATCH 05/12] mm, rmap: check all VMAs that PTE-mapped THP can be part of "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:40 +0100
  [PATCH 02/12] mm: introduce page_check_walk() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:40 +0100
    Re: [PATCH 02/12] mm: introduce page_check_walk() Andrew Morton <akpm@linux-foundation.org> - 2017-01-24 22:50 +0100
      Re: [PATCH 02/12] mm: introduce page_check_walk() Andrew Morton <akpm@linux-foundation.org> - 2017-01-25 00:00 +0100
        Re: [PATCH 02/12] mm: introduce page_check_walk() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-25 19:00 +0100
      Re: [PATCH 02/12] mm: introduce page_check_walk() "Kirill A. Shutemov" <kirill@shutemov.name> - 2017-01-25 00:00 +0100
    Re: [PATCH 02/12] mm: introduce page_check_walk() kbuild test robot <lkp@intel.com> - 2017-01-25 02:30 +0100
    Re: [PATCH 02/12] mm: introduce page_check_walk() kbuild test robot <lkp@intel.com> - 2017-01-25 03:10 +0100
  [PATCH 09/12] mm, uprobes: convert __replace_page() to page_check_walk() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2017-01-24 17:40 +0100
    Re: [PATCH 09/12] mm, uprobes: convert __replace_page() to  page_check_walk() Srikar Dronamraju <srikar@linux.vnet.ibm.com> - 2017-01-26 04:10 +0100

csiph-web