Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1567023

Re: [PATCHv4] mfd: cpcap: Add minimal support

Show all headers | View raw

* Lee Jones <lee.jones@linaro.org> [170124 01:32]:
> On Thu, 05 Jan 2017, Tony Lindgren wrote:
> > +
> > +	bit = irq % cpcap->regmap_conf->val_bits;
> > +	mask = (1 << bit);
> 
> Nit: BIT()
...
> > + * Copyright (C) 2016 Tony Lindgren <tony@atomide.com>
> 
> Nit: 2017
...
> > +/*
> > + * Helpers for child devices to check the revision and vendor.
> > + *
> > + * REVISIT: No documentation for the bits below, please update
> > + * to use proper names for defines when available.
> > + */
> 
> Yes, please do that.
> 
> But you can do all of the above with subsequent patches.

OK I'll send you a BIT() follow-up patch.

> Applied, thanks.

Thanks, not seeing it in next or mfd git tree yet though, forgot
to push out?

Regards,

Tony

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCHv4] mfd: cpcap: Add minimal support Lee Jones <lee.jones@linaro.org> - 2017-01-24 10:40 +0100
  Re: [PATCHv4] mfd: cpcap: Add minimal support Tony Lindgren <tony@atomide.com> - 2017-01-25 23:50 +0100
    Re: [PATCHv4] mfd: cpcap: Add minimal support Lee Jones <lee.jones@linaro.org> - 2017-01-26 13:00 +0100

csiph-web