Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566960

Re: [PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig

Show all headers | View raw

On Monday, January 23, 2017 6:03:12 PM CET Bilal Amarni wrote:
> Currently in 32-bit userspace calling the keyctl syscall returns an ENOSYS error.
> 
> This makes sure the compatibility wrapper is registered.
> 
> Signed-off-by: Bilal Amarni <bilal.amarni@gmail.com>

While this looks technically correct, it doesn't seem very nice to the
other 64-bit architectures that may also be missing this.

> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 1117421..d76f70b 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -1030,6 +1030,10 @@ config SYSVIPC_COMPAT
>         def_bool y
>         depends on COMPAT && SYSVIPC
>  
> +config KEYS_COMPAT
> +       def_bool y
> +       depends on COMPAT && KEYS
> +

I see four copies of this in existing architectures, but none for
mips, parisc or tile. How about just moving this next to CONFIG_KEYS?

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig Bilal Amarni <bilal.amarni@gmail.com> - 2017-01-23 18:10 +0100
  Re: [PATCH] ARM64: enable CONFIG_KEYS_COMPAT in Kconfig Arnd Bergmann <arnd@arndb.de> - 2017-01-25 22:30 +0100
    [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig Bilal Amarni <bilal.amarni@gmail.com> - 2017-01-26 13:00 +0100
      Re: [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig kbuild test robot <lkp@intel.com> - 2017-01-26 14:00 +0100
        [PATCH] security/keys: add CONFIG_KEYS_COMPAT to Kconfig Bilal Amarni <bilal.amarni@gmail.com> - 2017-01-26 14:30 +0100

csiph-web