Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1566946

Re: [PATCH] i2c: busses: constify dev_pm_ops structures

From Wolfram Sang <wsa@the-dreams.de>
Newsgroups linux.kernel
Subject Re: [PATCH] i2c: busses: constify dev_pm_ops structures
Date 2017-01-25 22:10 +0100
Message-ID <t3CZk-6Zx-17@gated-at.bofh.it> (permalink)
References <sZPV8-1h6-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Sun, Jan 15, 2017 at 03:29:41PM +0530, Bhumika Goyal wrote:
> Declare dev_pm_ops structures as const as they are only stored in the pm
> field of a device_driver structure. This field is of type const, so
> dev_pm_ops structures having similar properties can be declared const
> too.
> 
> File size before: drivers/i2c/busses/i2c-omap.o
>    text	   data	    bss	    dec	    hex	filename
>    6814	    584	      0	   7398	   1ce6	drivers/i2c/busses/i2c-omap.o
> 
> File size after: drivers/i2c/busses/i2c-omap.o
>    text	   data	    bss	    dec	    hex	filename
>    7006	    392	      0	   7398	   1ce6	drivers/i2c/busses/i2c-omap.o
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Applied to for-next, thanks! I dropped the file size table from the
commit message, though. For me, it is clear enough without it.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH] i2c: busses: constify dev_pm_ops structures Wolfram Sang <wsa@the-dreams.de> - 2017-01-25 22:10 +0100

csiph-web