Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1566894

Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module

Show all headers | View raw

On Wed, Jan 25, 2017 at 12:50:28PM +0100, Marek Szyprowski wrote:
> Exynos5433 LPASS module requires some clocks for proper operation with
> power domain.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> index 57c7bbeb65a7..16072c1c3ed3 100644
> --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi
> @@ -1494,6 +1494,8 @@
>  		audio-subsystem@11400000 {
>  			compatible = "samsung,exynos5433-lpass";
>  			reg = <0x11400000 0x100>, <0x11500000 0x08>;
> +			clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> +			clock-names = "sfr0_ctrl";

You wrote that 6/7 depends on this. I prefer not to take DTS changes if
the corresponding user (driver) is still under discussion because the
bindings might change. I'll take it when bindings got acked or accepted.

BTW, the 6/7 is a quite reasonable ABI break, but for the sake of
documentation - why you did not continue with the patch for marking
bidings as experimental/under-development?

Best regards,
Krzysztof

>  			samsung,pmu-syscon = <&pmu_system_controller>;
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -- 
> 1.9.1
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] Pad retentions support for Exynos5433 Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
  [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS  module Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 21:00 +0100
      Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS  module Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 08:20 +0100
        Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS  module Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-26 09:50 +0100
        Re: [PATCH 4/7] arm64: dts: exynos: Add clocks to Exynos5433 LPASS module Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-26 09:50 +0100
  [PATCH 6/7] mfd: exynos-lpass: Add support for clocks Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 6/7] mfd: exynos-lpass: Add support for clocks Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 21:10 +0100
      Re: [PATCH 6/7] mfd: exynos-lpass: Add support for clocks Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 21:10 +0100
  [PATCH 7/7] mfd: exynos-lpass: Add runtime PM support Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 7/7] mfd: exynos-lpass: Add runtime PM support Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 21:10 +0100
  [PATCH 2/7] pinctrl: samsung: Ensure that pad retention is disabled on  driver init Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 2/7] pinctrl: samsung: Ensure that pad retention is  disabled on driver init Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 18:40 +0100
  [PATCH 3/7] pinctrl: samsung: Add support for pad retention control  for Exynos5433 SoCs Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 3/7] pinctrl: samsung: Add support for pad retention  control for Exynos5433 SoCs Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 20:00 +0100
  [PATCH 5/7] mfd: exynos-lpass: Remove pad retention control Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 5/7] mfd: exynos-lpass: Remove pad retention control Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 21:00 +0100
    Re: [PATCH 5/7] mfd: exynos-lpass: Remove pad retention control Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-01-26 10:30 +0100
  [PATCH 1/7] soc: samsung: pmu: Add dummy support for Exynos5433 SoC Marek Szyprowski <m.szyprowski@samsung.com> - 2017-01-25 13:00 +0100
    Re: [PATCH 1/7] soc: samsung: pmu: Add dummy support for Exynos5433  SoC Krzysztof Kozlowski <krzk@kernel.org> - 2017-01-25 18:40 +0100

csiph-web