Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1565524

Re: [PATCH] i2c: Fix error print when address is invalid

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Jan 23, 2017 at 06:24:24PM -0800, Stephen Boyd wrote:
> When the address is invalid, we print out the address that's
> in info.addr, but that member of info hasn't been assigned yet.
> It's assigned in the line after we check the address. This causes
> the print to show something like
> 
>      i2c i2c-1: of_i2c: invalid addr=0 on ...
> 
> when we want something like
> 
>      i2c i2c-1: of_i2c: invalid addr=0xaf on ...
> 
> Just pass addr here, and update the print format to indicate hex
> as well.
> 
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>

Thanks, yet already fixed since v4.10-rc4 with 6f724fb3039522 ("i2c:
print correct device invalid address").

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: Fix error print when address is invalid Stephen Boyd <stephen.boyd@linaro.org> - 2017-01-24 03:30 +0100
  Re: [PATCH] i2c: Fix error print when address is invalid Wolfram Sang <wsa@the-dreams.de> - 2017-01-24 09:00 +0100

csiph-web