Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
Date	2017-01-22 23:40 +0100
Message-ID	<t2yXL-6yI-13@gated-at.bofh.it> (permalink)
References	<t2kUO-6jo-25@gated-at.bofh.it> <t2ovn-9n-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jan 22, 2017 at 03:25:57AM -0800, Guenter Roeck wrote:
> On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> >Nobody calls input_get_drvdata() so setting it is not required.
> >
> >Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> Surprisingly, there is about a dozen of those. I'll send a series of
> coccinelle generated patches later.

Cool, thanks.

> 
> Guenter
> 
> >---
> > drivers/input/touchscreen/max11801_ts.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> >index d87b89da114e..a595ae5284e3 100644
> >--- a/drivers/input/touchscreen/max11801_ts.c
> >+++ b/drivers/input/touchscreen/max11801_ts.c
> >@@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
> > 	__set_bit(BTN_TOUCH, input_dev->keybit);
> > 	input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
> > 	input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> >-	input_set_drvdata(input_dev, data);
> >
> > 	max11801_ts_phy_init(data);
> >
> >
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: max11801_ts - drop call to input_set_drvdata() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-22 08:40 +0100
  Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata() Guenter Roeck <linux@roeck-us.net> - 2017-01-22 12:30 +0100
    Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-01-22 23:40 +0100

csiph-web